Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtest --include-ignored nightly-gating is confusing #65770

Closed
ehuss opened this issue Oct 24, 2019 · 1 comment · Fixed by #80053
Closed

libtest --include-ignored nightly-gating is confusing #65770

ehuss opened this issue Oct 24, 2019 · 1 comment · Fixed by #80053
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-libtest Area: `#[test]` / the `test` library A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Oct 24, 2019

The libtest --include-ignored flag is intended to be unstable, but it does not present a clear way to use it.

> cargo +nightly test -- --include-ignored
error: The "include-ignored" flag is only accepted on the nightly compiler
error: test failed, to rerun pass '--lib'

Hmm, I'm running on nightly. Only through some sleuthing can one find out that you have to pass -Zunstable-options to make it work:

cargo +nightly test -- --include-ignored -Zunstable-options

There are several issues here (some of which were noted in the original PR):

  • The text "is only accepted on the nightly compiler" should probably say something about -Zunstable-options.
  • The text "is only accepted on the nightly compiler" is wrong, it works on stable, too. And this isn't a compiler.
  • There is no tracking issue for this feature, so there is nowhere to discuss it. Should one be created?
  • The --help text gives no indication that this flag is unstable.
  • Is there any reason not to just stabilize it now?
@ehuss ehuss mentioned this issue Oct 24, 2019
Closed
@jonas-schievink jonas-schievink added A-diagnostics Area: Messages for errors, warnings, and lints A-libtest Area: `#[test]` / the `test` library C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-stability Area: `#[stable]`, `#[unstable]` etc. labels Oct 24, 2019
@workingjubilee workingjubilee mentioned this issue Mar 24, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 24, 2020
@Centril
Rollup merge of rust-lang#70350 - workingjubilee:patch-1, r=Dylan-DPC
d214a2e 
Request "-Z unstable-options" for unstable options

Explicitly requests the "-Z unstable-options" flag if someone attempts to use
a cargo option gated by it. This enhances discoverability, particularly in the
instance where the user is on the nightly compiler but isn't using the flag.

This relates to, but does not end with or resolve, issue rust-lang#65770.
Centril added a commit to Centril/rust that referenced this issue Mar 24, 2020
@Centril
Rollup merge of rust-lang#70350 - workingjubilee:patch-1, r=Dylan-DPC
f8ec23f 
Request "-Z unstable-options" for unstable options

Explicitly requests the "-Z unstable-options" flag if someone attempts to use
a cargo option gated by it. This enhances discoverability, particularly in the
instance where the user is on the nightly compiler but isn't using the flag.

This relates to, but does not end with or resolve, issue rust-lang#65770.
@ehuss ehuss mentioned this issue Aug 14, 2020
Closed
@gilescope
Copy link
Contributor

I think it's a footgun that cargo test -- --ignored is the only stable option. We should eliminate that footgun by stabilising --include-ignored.

How does one nominate for stabilising something?

@gilescope gilescope mentioned this issue Dec 15, 2020
Merged
@bors bors closed this as completed in b28a1b2 Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-libtest Area: `#[test]` / the `test` library A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stabilise cargo test -- --include-ignored gilescope/rust
3 participants
@ehuss @gilescope @jonas-schievink