Were all the run-make tests meant to to be moved to run-make-fulldeps? #66085
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
pnkfelix
added
T-compiler
|
I didn't want that PR to bounce and I didn't want to start testing more than we were already testing, so yes it was intentional that everything moved. It's true that some items could be moved back, I just didn't want to do the work to do that personally. |
|
That's fine; I just wanted to make sure there wasn't some reason I wasn't seeing for trying to move tests back to |
|
Also beware that run-make-fulldeps is now treated differently in CI for various reasons. For example, the macOS tests are split into separate runners because they take too long to run and run-make-fulldeps is one of the suites that is split up. Also, the "debug" runner only runs the run-make-fulldeps tests. |
oli-obk
pushed a commit
to oli-obk/miri
that referenced
this issue
Apr 4, 2023
Move almost all run-make-fulldeps tests to run-make They pass fine, and this avoids having to build the compiler twice. There are few enough tests left that I think it should be possible to get rid of this test suite altogether, but I expect this PR to fail at least a few times in bors and want to get it merged before tackling further changes. cc rust-lang/rust#83775 Fixes rust-lang/rust#66085. Fixes rust-lang/rust#83773.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#48883 moved the
run-maketests torun-make-fulldepsBut a lot of the
run-maketests can be run against the stage1 compiler.From the description on PR #48883, I am not clear on whether the
run-makemove torun-make-fulldepswas meant to be permanent, or just a temporary way to test a change that accidentally got committed.The text was updated successfully, but these errors were encountered: