Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abs function still not cleaned up from const_hack #67842

Closed
tspiteri opened this issue Jan 3, 2020 · 1 comment · Fixed by #67845
Closed

abs function still not cleaned up from const_hack #67842

tspiteri opened this issue Jan 3, 2020 · 1 comment · Fixed by #67845
Assignees
@rustbot

Comments

@tspiteri
Copy link
Contributor

tspiteri commented Jan 3, 2020 •
edited by rustbot
Loading

#67657 seems to have missed the abs function which is still hacky.

cc @oli-obk @jumbatm

This issue has been assigned to @jumbatm via this comment.
@jumbatm
Copy link
Contributor

jumbatm commented Jan 3, 2020

Oops, my bad. Opening up a PR now.

@rustbot claim

@rustbot rustbot self-assigned this Jan 3, 2020
@jumbatm jumbatm mentioned this issue Jan 3, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Jan 3, 2020
@Centril
Rollup merge of rust-lang#67845 - jumbatm:also-unconst-hack-abs, r=ol…
3f83bc8 
…i-obk

Also remove const-hack for abs

Closes rust-lang#67842.

r? @oli-obk
@bors bors closed this as completed in 745f771 Jan 4, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jan 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#67845 - jumbatm:also-unconst-hack-abs, r=ol…
21d9a09 
…i-obk

Also remove const-hack for abs

Closes rust-lang#67842.

r? @oli-obk
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jan 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#67845 - jumbatm:also-unconst-hack-abs, r=ol…
59f8ba3 
…i-obk

Also remove const-hack for abs

Closes rust-lang#67842.

r? @oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also remove const-hack for abs jumbatm/rust
3 participants
@tspiteri @jumbatm @rustbot