Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust/RELEASES.md doesn't list the Box<T> FFI change for 1.41.0 #68676

Closed
lilyball opened this issue Jan 30, 2020 · 1 comment · Fixed by #92506
Closed

rust/RELEASES.md doesn't list the Box<T> FFI change for 1.41.0 #68676

lilyball opened this issue Jan 30, 2020 · 1 comment · Fixed by #92506
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@lilyball
Copy link
Contributor

The announcement post for Rust 1.41.0 talks about Box<T> now being ABI-compatible with C's T* type, but I can't find any mention of that in the detailed release notes.
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 30, 2020
@jonas-schievink
Copy link
Contributor

The relevant PR is #62514 if someone wants to fix this.

@nico-abram nico-abram mentioned this issue Jan 3, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum
1d97d61 
Document Box<T> FFI guarantee in 1.41.0 release notes

Fixes rust-lang#68676
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum
df59daf 
Document Box<T> FFI guarantee in 1.41.0 release notes

Fixes rust-lang#68676
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 12, 2022
@matthiaskrgr
Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum
9ea9e18 
Document Box<T> FFI guarantee in 1.41.0 release notes

Fixes rust-lang#68676
@bors bors closed this as completed in fc8af98 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document Box<T> FFI guarantee in 1.41.0 release notes nico-abram/rust
2 participants
@lilyball @jonas-schievink