Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#81761 #81770

Closed
rust-highfive opened this issue Feb 5, 2021 · 5 comments · Fixed by #81824
Closed

miri no longer builds after rust-lang/rust#81761 #81770

rust-highfive opened this issue Feb 5, 2021 · 5 comments · Fixed by #81824
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #81761, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @m-ou-se, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Feb 5, 2021
@osa1
Copy link
Contributor

osa1 commented Feb 5, 2021

Where can I learn more about how this check is done? I just built stage 1 compiler with current master, and I was able to build miri with cargo +stage1 build.

@m-ou-se
Copy link
Member

m-ou-se commented Feb 5, 2021

I'm guessing one of the tests is failing because it now needs a #[allow(non_fmt_panic)]. The failure should be hidden somewhere in the logs of the toolstate runner: https://github.com/rust-lang-ci/rust/runs/1834930125

@m-ou-se
Copy link
Member

m-ou-se commented Feb 5, 2021

rust-lang/miri#1701 should fix tihs.

@osa1
Copy link
Contributor

osa1 commented Feb 5, 2021

Ah, so the problem is in one of the tests.. I only checked building.

bors added a commit to rust-lang/miri that referenced this issue Feb 5, 2021
Update rust version and update tests.

This is a fix for rust-lang/rust#81770
@RalfJung
Copy link
Member

RalfJung commented Feb 5, 2021

@osa1 usually, x.py test --stage 0 src/tools/miri should let you run the tests, but this is currently broken by #78778.

@RalfJung RalfJung mentioned this issue Feb 6, 2021
@bors bors closed this as completed in 37d067f Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants