Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that attributes passed to doc(test) are valid #82672

Closed
GuillaumeGomez opened this issue Mar 1, 2021 · 0 comments · Fixed by #87728
Closed

check that attributes passed to doc(test) are valid #82672

GuillaumeGomez opened this issue Mar 1, 2021 · 0 comments · Fixed by #87728
Assignees
@GuillaumeGomez
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

Discussed in #82662 (comment)
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 1, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 1, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 2, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 5, 2021
@GuillaumeGomez
Rollup merge of rust-lang#82708 - GuillaumeGomez:doc-test-attr-check,…
0dd9066 
… r=Manishearth

Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint

Part of rust-lang#82672.

This PR does multiple things:
 * Create a new `INVALID_DOC_ATTRIBUTE` lint which is also "future incompatible", allowing us to use it as a warning for the moment until it turns (eventually) into a hard error.
 * Use this link when `#![doc(test(...))]` isn't used at the crate level.
 * Make rust-lang#82702 use this new lint as well.

r? `@jyn514`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 5, 2021
@GuillaumeGomez
Rollup merge of rust-lang#82708 - GuillaumeGomez:doc-test-attr-check,…
8867f7f 
… r=Manishearth

Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint

Part of rust-lang#82672.

This PR does multiple things:
 * Create a new `INVALID_DOC_ATTRIBUTE` lint which is also "future incompatible", allowing us to use it as a warning for the moment until it turns (eventually) into a hard error.
 * Use this link when `#![doc(test(...))]` isn't used at the crate level.
 * Make rust-lang#82702 use this new lint as well.

r? ``@jyn514``
@camelid camelid self-assigned this Mar 11, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2021
Merged
@camelid camelid removed their assignment Aug 17, 2021
@bors bors closed this as completed in cbe3afe Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "doc(test(...))" attribute checks GuillaumeGomez/rust
3 participants
@Manishearth @GuillaumeGomez @camelid