Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Section icon covers part of enum variant name when hovered #87611

Closed
camelid opened this issue Jul 30, 2021 · 8 comments · Fixed by #87818
Closed

rustdoc: Section icon covers part of enum variant name when hovered #87611

camelid opened this issue Jul 30, 2021 · 8 comments · Fixed by #87818
Assignees
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jul 30, 2021

This is a regression from 1.53.0 to 1.54.0 (released today). It's likely that the display of other parts of the docs has regressed in a similar way as well (e.g., struct fields), but I haven't checked those.

More broadly, the way the variant looks when hovered has changed as well. I am unsure if that part of the change was intentional; to me it seems like a regression.

1.54.0 (incorrect)

image

1.53.0 (correct)

image

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 30, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 30, 2021
@apiraino
Copy link
Contributor

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-medium

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jul 31, 2021
@GuillaumeGomez
Copy link
Member

Fixing it.

@GuillaumeGomez GuillaumeGomez self-assigned this Aug 2, 2021
@GuillaumeGomez
Copy link
Member

It's actually already fixed in nightly and beta. Should we close it then?

@camelid
Copy link
Member Author

camelid commented Aug 3, 2021

It's actually already fixed in nightly and beta. Should we close it then?

It doesn't look fixed to me in the links you posted. When I hover over the None variant, the section icon still covers the word None, and the styling of the highlight is still different from 1.53.0.

EDIT: Ah, I realize what caused the confusion: you actually have to click on None, and then hover to see the problem. Or, you have to add the anchor #variant.None to the URL before visiting the page.

@GuillaumeGomez
Copy link
Member

That's interesting:

Screenshot from 2021-08-03 22-16-54

I love when dark magic is involved haha. Well, I'm gonna try to see how to reproduce it.

@camelid
Copy link
Member Author

camelid commented Aug 3, 2021

The bug is present in all themes, but it looks a bit different in Ayu:

image

As you can see, it looks like the section icon's background is overlapping with the text None.

@camelid
Copy link
Member Author

camelid commented Aug 3, 2021

Ayu seems to have also had a highlighting regression from stable to beta, perhaps separate from the one described in this issue?

stable

image

beta

image

@GuillaumeGomez
Copy link
Member

For for the background, it's definitely on purpose.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 18, 2021
@bors bors closed this as completed in 6d30039 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants