Generated docs on long pages render text on top of itself #88545

mqudsi · 2021-08-31T16:33:56Z

I hope this is the right repo to report this, I wasn't sure if it should go in the main rust repo instead.

The generated docs for pages with a crazy number of items seem to give up on positioning and then just dump all subsequent entries on the same line past a certain point. It looks like it might be related to hardware acceleration, but I'm not sure.

For example, viewing https://doc.rust-lang.org/beta/core/arch/arm/index.html in Chrome 92 on Windows and hitting ctrl+pgdwn to go to the very bottom shows this:

jyn514 · 2021-08-31T21:10:49Z

@mqudsi no worries - rustdoc is used for both docs.rs and the main doc.rust-lang.org website, but docs.rs doesn't have control over the main site.

jyn514 · 2021-08-31T21:13:10Z

I can't reproduce this on mobile Chrome though - maybe it's related to the screen size?

Seadragon91 · 2021-09-01T06:32:58Z

Can confirm that problem on my PC in Edge.
Also on my smartphone in Edge and Chrome, I need to change the view of the website to "Desktop website" then I see it there too.

camelid · 2021-09-01T21:41:15Z

I can't reproduce this in Firefox on macOS, but I can in Chrome on macOS. So I'm guessing it's a bug specific to Blink because I think Chrome and Edge both use Blink, whereas Firefox does not.

ChrisDenton · 2021-09-01T21:51:09Z

It seems to be a bug with Blink's grid implementation. If I turn off the display: grid style it works (but obviously changes the layout).

mqudsi · 2021-09-01T23:12:52Z

It seems to be a bug with Blink's grid implementation. If I turn off the display: grid style it works (but obviously changes the layout).

I’m not saying it’s not grid, but just pointing out that changing the display completely changes the layout and so may avoid the problem even if it’s something else. In theory, anyway.

ChrisDenton · 2021-09-01T23:26:55Z

Fair point. A minimal test case appears to show the same issue but I'll admit that does not necessarily determine the root cause:

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <title>Test display grid with lots of children</title>
</head>

<body style="display: grid;">
<script>
for (let i = 0; i < 600; i++) {
    document.write(`<div>Testing</div>`);
    document.write(`<div>Overtype</div>`);
}
</script>
</body></html>

mqudsi · 2021-09-01T23:50:36Z

I think your test case confirms the cause, at least from a black box perspective, sufficiently ;)

dbalcomb · 2021-09-06T15:49:28Z

It looks like this issue was previously reported here and there are some relevant links towards the end. Notably a confirmation that there is currently a 1000 row limit to grids in Blink. There is also a recent reddit thread on the issue.

GuillaumeGomez · 2021-09-08T18:32:40Z

Do you have an idea @dns2utf8 ? The best would be to not use grid at all. If you have no idea, I'll send a fix in the next coming days.

dns2utf8 · 2021-09-09T11:11:55Z

I can confirm this with Chromium 93 and IE Edge 91.
I tried adding a <br> after the grid-layout (works with floats sometimes) but will try some more.

It works with Firefox 91 and 92 so I assume it is a chrome render-engine bug.

ChrisDenton · 2021-09-09T11:17:00Z

Yes it's a Blink bug: https://bugs.chromium.org/p/chromium/issues/detail?id=688640

GuillaumeGomez · 2021-09-09T11:22:57Z

@dns2utf8 Which is why I think we should switch to another way of rendering which doesn't use the current grid at all (firefox also has a limit, it's just a higher one).

dns2utf8 · 2021-09-09T12:02:49Z

Hm, ... I see your point.
Since it solves the viewport-scaling with mobile very nicely, what if we split the table into 1000 element chunks?
That would not make a difference on mobile and on desktop we would just loose the width consistency of the first column every 1000 element.

GuillaumeGomez · 2021-09-09T12:06:38Z

I don't think this is a good idea. I'd really prefer to not rely on "limits" that could change independently outside of our control. I think we need to find another approach.

See rust-lang#88545 for more details

dns2utf8 · 2021-09-09T13:57:37Z

One idea I have is that we switch back to the table element if the table is too long.
This I would probably implement in the HTML generator.

Another one, we use the mobile layout on desktop too if the table is too long.
Here I would add a check in JavaScript to see if the last two elements overlap and then add a class that switches the behaviour.

Or something else ☺️

GuillaumeGomez · 2021-09-09T14:01:27Z

The annoying part is that the left column has to be the width of the largest element. Maybe we could rework that part so it doesn't need something so complicated and keep how it's displayed on mobile? If you have suggestions... :)

mqudsi · 2021-09-09T14:04:07Z

cough tables cough.

But seriously, if you use a css reset to remove all browser styling (are we already doing that?) you can use the table layout in the renderer to create code like our current grid (because we are barely using any of the actual grid features). A little bit of css to the cell classes makes it responsive.

GuillaumeGomez · 2021-09-09T14:06:00Z

Or maybe we can do even simpler and just set width to both parts to 50% (or 30-70, well up to debate). Like this, the alignment for the right part will work and we don't need to worry about grid or table anymore.

dns2utf8 · 2021-09-09T15:14:00Z

In the upcoming CSS Grid-2 spec (https://www.w3.org/TR/css-grid-2/#overlarge-grids) there is this sentence:

...  in the range [-10000, 10000]), dropping all lines outside that limit.

So we would run into trouble if a table gets longer than 10k entries.

However:

... if a UA only supported grids with at most 1000 tracks in each dimension, the following placement properties:
  grid-row:
  grid-column:

To me the spec reads as, the UA (User Agent aka Browser) is free to enforce lower limits if there is not enough memory available.

I would like to look at the display: table* because that would allow us to keep the automatic layout switching on mobile (and support for it looks good) https://caniuse.com/?search=table

…ements_grid_bug, r=GuillaumeGomez Workaround blink/chromium grid layout limitation of 1000 rows I made this in case we don't come up with a better solution in time. See rust-lang#88545 for more details. A rendered version of the standard library is hosted here: https://data.estada.ch/rustdoc-nightly_497ee321af_2021-09-09/core/arch/arm/index.html r? `@GuillaumeGomez` `@jsha`

…ation of 1000 rows See rust-lang#88545 for more details

See rust-lang#88545 for more details (cherry picked from commit 0bf16af)

jyn514 · 2021-09-15T21:23:46Z

This was fixed by #88776, right?

GuillaumeGomez · 2021-09-15T21:27:16Z

I'm waiting for #88816 before closing it.

camelid · 2021-09-16T01:00:57Z

@GuillaumeGomez Can you add Closes <this issue number> to the PR description then, to make sure the issue is closed on merge?

Detects rust-lang#88545

…nts, r=GuillaumeGomez Rustdoc migrate to table so the gui can handle >2k constants Closes rust-lang#88545. This PR adds a test for overlapping entries in the `item-table` rust-lang#88545 It currently includes the commit with the workaround from rust-lang#88776

Detects rust-lang#88545

jyn514 transferred this issue from rust-lang/docs.rs Aug 31, 2021

jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 31, 2021

jyn514 added A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. labels Aug 31, 2021

dns2utf8 added a commit to dns2utf8/rust that referenced this issue Sep 9, 2021

Workaround blink/chromium grid layout limitation of 1000 rows

0bf16af

See rust-lang#88545 for more details

dns2utf8 mentioned this issue Sep 9, 2021

Workaround blink/chromium grid layout limitation of 1000 rows #88776

Merged

dns2utf8 mentioned this issue Sep 10, 2021

Rustdoc migrate to table so the gui can handle >2k constants #88816

Merged

dns2utf8 added a commit to dns2utf8/rust that referenced this issue Sep 11, 2021

Backport rust-lang#88776: Workaround blink/chromium grid layout limit…

5fb9625

…ation of 1000 rows See rust-lang#88545 for more details

dns2utf8 mentioned this issue Sep 11, 2021

[beta] Workaround blink/chromium grid layout limitation of 1000 rows #88861

Closed

cuviper pushed a commit to cuviper/rust that referenced this issue Sep 14, 2021

Workaround blink/chromium grid layout limitation of 1000 rows

6387590

See rust-lang#88545 for more details (cherry picked from commit 0bf16af)

Mark-Simulacrum pushed a commit to dns2utf8/rust that referenced this issue Oct 3, 2021

Add a test to detect overlapping entries in overview tables

a0cc9bb

Detects rust-lang#88545

bors closed this as completed in 52d3afa Oct 5, 2021

dns2utf8 added a commit to dns2utf8/rust that referenced this issue Oct 9, 2021

Add a test to detect overlapping entries in overview tables

ad92e9e

Detects rust-lang#88545

GuillaumeGomez mentioned this issue Oct 10, 2021

rustdoc: use flexbox to layout sidebar and main content #89385

Closed

notriddle mentioned this issue Jul 8, 2024

[rustdoc] Feature Request: Allow code wrapping #127334

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generated docs on long pages render text on top of itself #88545

Generated docs on long pages render text on top of itself #88545

mqudsi commented Aug 31, 2021

jyn514 commented Aug 31, 2021

jyn514 commented Aug 31, 2021

Seadragon91 commented Sep 1, 2021

camelid commented Sep 1, 2021

ChrisDenton commented Sep 1, 2021

mqudsi commented Sep 1, 2021

ChrisDenton commented Sep 1, 2021 •

edited

Loading

mqudsi commented Sep 1, 2021

dbalcomb commented Sep 6, 2021

GuillaumeGomez commented Sep 8, 2021

dns2utf8 commented Sep 9, 2021

ChrisDenton commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021 •

edited

Loading

dns2utf8 commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

dns2utf8 commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

mqudsi commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

dns2utf8 commented Sep 9, 2021

jyn514 commented Sep 15, 2021

GuillaumeGomez commented Sep 15, 2021

camelid commented Sep 16, 2021 •

edited

Loading

Generated docs on long pages render text on top of itself #88545

Generated docs on long pages render text on top of itself #88545

Comments

mqudsi commented Aug 31, 2021

jyn514 commented Aug 31, 2021

jyn514 commented Aug 31, 2021

Seadragon91 commented Sep 1, 2021

camelid commented Sep 1, 2021

ChrisDenton commented Sep 1, 2021

mqudsi commented Sep 1, 2021

ChrisDenton commented Sep 1, 2021 • edited Loading

mqudsi commented Sep 1, 2021

dbalcomb commented Sep 6, 2021

GuillaumeGomez commented Sep 8, 2021

dns2utf8 commented Sep 9, 2021

ChrisDenton commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021 • edited Loading

dns2utf8 commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

dns2utf8 commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

mqudsi commented Sep 9, 2021

GuillaumeGomez commented Sep 9, 2021

dns2utf8 commented Sep 9, 2021

jyn514 commented Sep 15, 2021

GuillaumeGomez commented Sep 15, 2021

camelid commented Sep 16, 2021 • edited Loading

ChrisDenton commented Sep 1, 2021 •

edited

Loading

GuillaumeGomez commented Sep 9, 2021 •

edited

Loading

camelid commented Sep 16, 2021 •

edited

Loading