Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle mingw dll with stage0 package #9252

Closed
klutzy opened this issue Sep 17, 2013 · 2 comments
Closed

Bundle mingw dll with stage0 package #9252

klutzy opened this issue Sep 17, 2013 · 2 comments
Labels
O-windows Operating system: Windows

Comments

@klutzy
Copy link
Contributor

klutzy commented Sep 17, 2013

Currently mingw stage0 package does not contain mingw runtime libraries: libgcc_s_dw2-1.dll, libstdc++-6.dll, libpthread-2.dll.
However, mingw sometimes upgrades dll and the installer installs latest one as default. This makes a lot of problems and confusions.

Instead, we can bundle dlls with stage0 archive then we only depend on external g++ executable, not any runtime libraries.

This may also help upgrading mingw (#8598): currently, if you want to build rust with recent mingw or mingw-w64 (#8996), you have to copy old dlls at <builddir>/<triple>/stage0/bin/. It is really inconvenient.
@vadimcn
Copy link
Contributor

vadimcn commented Sep 24, 2013

@alexcrichton, @brson: Is there a general agreement that this is what we want to do?

And if so, can we assume that Windows snapshot tar file will be created on a Windows machine? ('cause I am not sure that mingw runtime dlls are present in Linux mingw cross-compiler environment).

@klutzy
Copy link
Contributor Author

klutzy commented Sep 25, 2013

cc #5712

@vadimcn vadimcn mentioned this issue Oct 1, 2013
Closed
@bors bors closed this as completed in 8bb55db Oct 4, 2013
@ubershmekel ubershmekel mentioned this issue Oct 9, 2013
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2022
@bors
Auto merge of rust-lang#9252 - Metaswitch:use-deprecated-config, r=Ja…
53a09d4 
…rcho

Read and use deprecated configuration (as well as emitting a warning)

Original change written by `@flip1995` I've simply rebased to master and fixed up the formatting/tests.  This change teaches the configuration parser which config key replaced a deprecated key and attempts to populate the latter from the former.  If both keys are provided this fails with a duplicate key error (rather than attempting to guess which the user intended).

Currently this on affects `cyclomatic-complexity-threshold` -> `cognitive-complexity-threshold` but will also be used in rust-lang#8974 to handle `blacklisted-names` -> `disallowed-names`.

```
changelog: deprecated configuration keys are still applied as if they were provided as their non-deprecated name.
```

- [x] `cargo test` passes locally
- [x] Run `cargo dev fmt`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows: package system runtime dependencies vadimcn/rust
2 participants
@klutzy @vadimcn