Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an extensionless x script for non-Windows #100468

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 12, 2022

#99992 added x.sh and x.ps1, but this broke my lazy ./xTAB habit that used to get me to ./x.py. If we rename x.sh to x, then I can adjust to ./xSPACE for the same number of characters typed.

r? @jyn514

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 12, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 12, 2022

If we rename x.sh to x, then I can adjust to ./xSPACE for the same number of characters typed.

ah, bash will no longer autocomplete the space because of the .ps1 script, that's unfortunate. Well, seems unavoidable unless we name the PowerShell script something else, which I'd rather avoid.

Thanks for the PR!

@jyn514
Copy link
Member

jyn514 commented Aug 12, 2022

@bors r+

(on mobile, not 100% sure you caught all occurrences, but the worst that should happen is CI fails)

@bors
Copy link
Contributor

bors commented Aug 12, 2022

📌 Commit de8dedb has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2022
@dtolnay
Copy link
Member

dtolnay commented Aug 13, 2022

But why would one want to type ./xTAB or ./xSPACE when one can alias x=./x.py and type xSPACE, which is half the keys? 🤣

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2022
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99646 (Only point out a single function parameter if we have a single arg incompatibility)
 - rust-lang#100299 (make `clean::Item::span` return `Option` instead of dummy span)
 - rust-lang#100335 (Rustdoc-Json: Add `Path` type for traits.)
 - rust-lang#100367 (Suggest the path separator when a dot is used on a trait)
 - rust-lang#100431 (Enum variant ctor inherits the stability of the enum variant)
 - rust-lang#100446 (Suggest removing a semicolon after impl/trait items)
 - rust-lang#100468 (Use an extensionless `x` script for non-Windows)
 - rust-lang#100479 (Argument type error improvements)

Failed merges:

 - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 809fc86 into rust-lang:master Aug 14, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 14, 2022
@cuviper cuviper deleted the lazy-x branch October 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants