Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of dyn* #101212

Merged
merged 16 commits into from
Sep 14, 2022
Merged

Initial implementation of dyn* #101212

merged 16 commits into from
Sep 14, 2022

Commits on Sep 12, 2022

  1. Introduce dyn_star feature flag 

    The primary purpose of this commit is to introduce the
dyn_star flag so we can begin experimenting with implementation.

In order to have something to do in the feature gate test, we also add
parser support for `dyn* Trait` objects. These are currently treated
just like `dyn Trait` objects, but this will change in the future.

Note that for now `dyn* Trait` is experimental syntax to enable
implementing some of the machinery needed for async fn in dyn traits
without fully supporting the feature.
    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    eff35e5 View commit details
    Browse the repository at this point in the history

  2. Plumb dyn trait representation through ty::Dynamic

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6c01273 View commit details
    Browse the repository at this point in the history

  3. Typecheck dyn* coercions 

    Also changes things to treat dyn* as a sized type, unlike dyn Trait.
    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    7fccac3 View commit details
    Browse the repository at this point in the history

  4. dyn* through more typechecking and MIR

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    549c105 View commit details
    Browse the repository at this point in the history

  5. Call destructors when dyn* object goes out of scope

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c5441ac View commit details
    Browse the repository at this point in the history

  6. Add test case for calling methods on dyn* object

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    48e7f24 View commit details
    Browse the repository at this point in the history

  7. Add test to make sure we run custom destructors

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ef7062d View commit details
    Browse the repository at this point in the history

  8. Use principal of cast target as dyn-star trait ref in codegen

    @compiler-errors @eholk
    compiler-errors authored and eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    12353c1 View commit details
    Browse the repository at this point in the history

  9. Construct dyn* during const interp

    @compiler-errors @eholk
    compiler-errors authored and eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    12ec2f0 View commit details
    Browse the repository at this point in the history

  10. Rename some variants

    @compiler-errors @eholk
    compiler-errors authored and eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    b2ed2dc View commit details
    Browse the repository at this point in the history

  11. Make dyn-trait-method work

    @compiler-errors @eholk
    compiler-errors authored and eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    03148ff View commit details
    Browse the repository at this point in the history

  12. Update feature flags on dyn-star tests

    @eholk
    eholk committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ddfcca4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Make x.py check work

    @eholk
    eholk committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3c2d20e View commit details
    Browse the repository at this point in the history

  2. Move dyn* tests to their own directory

    @eholk
    eholk committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    de42ac3 View commit details
    Browse the repository at this point in the history

  3. Address code review comments

    @eholk
    eholk committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    cf04547 View commit details
    Browse the repository at this point in the history

  4. Update parsing test

    @eholk
    eholk committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    0faafbf View commit details
    Browse the repository at this point in the history