Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make projection bounds with const bounds satisfy const #101989

Merged
merged 1 commit into from
Sep 20, 2022
Merged

make projection bounds with const bounds satisfy const #101989

merged 1 commit into from
Sep 20, 2022

Conversation

fee1-dead
Copy link
Member

Fixes #101982.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 18, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead fee1-dead force-pushed the const_trait_impl-assoc-caller-bounds branch from 4bd048b to ee96ae0 Compare September 18, 2022 18:05
@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 20, 2022
@bors
Copy link
Contributor

bors commented Sep 20, 2022

⌛ Trying commit ee96ae0 with merge b2e9cc6434c548977f066bc6b2e83f101cde5d2c...

@bors
Copy link
Contributor

bors commented Sep 20, 2022

☀️ Try build successful - checks-actions
Build commit: b2e9cc6434c548977f066bc6b2e83f101cde5d2c (b2e9cc6434c548977f066bc6b2e83f101cde5d2c)

@rust-timer
Copy link
Collaborator

Queued b2e9cc6434c548977f066bc6b2e83f101cde5d2c with parent acb8934, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b2e9cc6434c548977f066bc6b2e83f101cde5d2c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.7% [4.0%, 5.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.1% [2.0%, 2.2%] 2
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.1% [2.0%, 2.2%] 2

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 20, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 20, 2022

📌 Commit ee96ae0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2022
@bors
Copy link
Contributor

bors commented Sep 20, 2022

⌛ Testing commit ee96ae0 with merge cd8cc91...

@bors bors mentioned this pull request Sep 20, 2022
Merged
@bors
Copy link
Contributor

bors commented Sep 20, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing cd8cc91 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2022
@bors bors merged commit cd8cc91 into rust-lang:master Sep 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 20, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cd8cc91): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@oli-obk oli-obk deleted the const_trait_impl-assoc-caller-bounds branch September 21, 2022 07:31
yvt added a commit to r3-os/r3 that referenced this pull request Nov 10, 2022
@yvt
refactor(core): associated types can now imply ~const Trait
67972c7 
`[ref:const_trait_not_implied]` has been resolved by
[rust-lang/rust#101989][1].

[1]: rust-lang/rust#101989
@fee1-dead fee1-dead mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Compiler doesn't think that an associate type implements const trait
7 participants
@fee1-dead @rust-highfive @rust-log-analyzer @oli-obk @rust-timer @bors @rustbot