Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RtlGenRandom (take two) #102044

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

ChrisDenton
Copy link
Member

First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2022
@ChrisDenton
Copy link
Member Author

ChrisDenton commented Sep 20, 2022

Beta branched just recently so by doing this now it'll have the longest time in nightly/beta, which should give plenty of time for fixes in the (hopefully) unlikely event there are still issues.

library/std/src/sys/windows/rand.rs Outdated Show resolved Hide resolved
First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.
@thomcc
Copy link
Member

thomcc commented Sep 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 20, 2022

📌 Commit 8ca6a27 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2022
…thomcc

Remove `RtlGenRandom` (take two)

First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 24, 2022
…thomcc

Remove `RtlGenRandom` (take two)

First try to use the system preferred RNG but if that fails (e.g. due to a broken system configuration) then fallback to manually opening an algorithm handle.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#101780 (Add a platform support document for Android)
 - rust-lang#102044 (Remove `RtlGenRandom` (take two))
 - rust-lang#102081 (Adding ignore fuchsia tests for execvp (pre_exec))
 - rust-lang#102082 (Adding ignore fuchsia non-applicable commands)
 - rust-lang#102146 (rustdoc: CSS prevent sidebar width change jank)
 - rust-lang#102152 (Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly)
 - rust-lang#102175 (Also require other subtrees to always build successfully)
 - rust-lang#102176 (Add `llvm-dis` to the set of tools in `ci-llvm`)
 - rust-lang#102188 (Update doc after renaming `fn is_zero`)
 - rust-lang#102199 (Improve rustdoc GUI tests)
 - rust-lang#102218 (Document some missing command-line arguments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3baf5f8 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@ChrisDenton ChrisDenton deleted the BCrypt-system-rand branch September 24, 2022 09:50
badboy added a commit to badboy/getrandom that referenced this pull request Jan 11, 2023
badboy added a commit to badboy/getrandom that referenced this pull request Jan 11, 2023
badboy added a commit to badboy/getrandom that referenced this pull request Jan 11, 2023
badboy added a commit to badboy/getrandom that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants