Revert "Allow ~const bounds on non-const functions"
#102409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Sep 28, 2022
Comment on lines
+20
to
+24
| fn generic<P: ~const T>() {} | ||
| //~^ ERROR `~const` is not allowed | ||
|
|
||
| fn where_clause<P>() where P: ~const T {} | ||
| //~^ ERROR `~const` is not allowed |
There was a problem hiding this comment.
Afaict from the impl, these functions would be accepted if they were in an impl block. They should only be allowed if the impl block is for a const Trait impl.
lilasta
reviewed
Sep 28, 2022
| || matches!(fk.ctxt(), Some(FnCtxt::Assoc(_))); | ||
| let tilde_const_allowed = | ||
| matches!(fk.header(), Some(FnHeader { constness: Const::Yes(_), .. })) | ||
| || matches!(fk.ctxt(), Some(FnCtxt::Assoc(_))); |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
☔ The latest upstream changes (presumably #102666) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #102273.
It is not sound to use
~constbounded trait types in const_generics because const_generics requires the type to beconstat all times, while~constdoes not guarantee that.r? @oli-obk