Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable x.py check for miri #102950

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Enable x.py check for miri #102950

merged 4 commits into from
Nov 1, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 12, 2022

Now that the miri subtree is working properly, let's add it to x.py check.

cc @rust-lang/miri

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 12, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022
src/bootstrap/tool.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

r? @RalfJung
r=me when CI is green

Was this the thing that caused doc failures? We might have to add that recursion limit attribute the error message was talking about...

@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 12, 2022

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Oct 12, 2022

📌 Commit 0227d8d has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2022
Enable `x.py check` for miri

Now that the miri subtree is working properly, let's add it to x.py check.

cc `@rust-lang/miri`
src/bootstrap/tool.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 13, 2022

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit c4b9b65 has been approved by RalfJung

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2022
Enable `x.py check` for miri

Now that the miri subtree is working properly, let's add it to x.py check.

cc `@rust-lang/miri`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2022
Enable `x.py check` for miri

Now that the miri subtree is working properly, let's add it to x.py check.

cc ``@rust-lang/miri``
@matthiaskrgr
Copy link
Member

@bors r- rollup=iffy failed in a rollup
#103097

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 15, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2022
library: allow some unused things in Miri

Should help for rust-lang#102950.
@RalfJung
Copy link
Member

All right, time for another attempt.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 27, 2022

📌 Commit f882309 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2022
@bors
Copy link
Contributor

bors commented Oct 29, 2022

⌛ Testing commit f882309 with merge f46c1c5f28a0c1abeaf463951b7fe17eb40d5b26...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Oct 29, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2022
@RalfJung
Copy link
Member

RalfJung commented Oct 29, 2022

Ah, that error is back

  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`miri`)

No idea why this occurs here, when actually generating the documentation for https://doc.rust-lang.org/nightly/nightly-rustc/miri/index.html works perfectly fine. But maybe we should just add that attribute? A lot of rustc crates seem to have it, too, possibly for the same reason.

@jyn514
Copy link
Member

jyn514 commented Oct 31, 2022

Ah, that error is back

  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`miri`)

No idea why this occurs here, when actually generating the documentation for https://doc.rust-lang.org/nightly/nightly-rustc/miri/index.html works perfectly fine. But maybe we should just add that attribute? A lot of rustc crates seem to have it, too, possibly for the same reason.

That seems reasonable. Bootstrap documents compiler crates with -Znormalize-docs so it doesn't surprise me that rustdoc hits the type length limit sooner than when rustc builds the crate.

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2022

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member

Okay, let's do that then -- I pushed it to this PR.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2022

📌 Commit b35e2bf has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2022
@bors
Copy link
Contributor

bors commented Oct 31, 2022

⌛ Testing commit b35e2bf with merge 024207a...

@bors
Copy link
Contributor

bors commented Nov 1, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 024207a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 1, 2022
@bors bors merged commit 024207a into rust-lang:master Nov 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 1, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (024207a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.4%, -1.2%] 2
Improvements ✅
(secondary)
-3.5% [-4.0%, -3.1%] 6
All ❌✅ (primary) -1.3% [-1.4%, -1.2%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
Enable `x.py check` for miri

Now that the miri subtree is working properly, let's add it to x.py check.

cc `@rust-lang/miri`
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
library: allow some unused things in Miri

Should help for rust-lang/rust#102950.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.