-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first move on a nested span_label #103559
Conversation
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
r? @davidtwco |
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay in reviewing this.
This comment has been minimized.
This comment has been minimized.
f4d3ba5
to
35c9b91
Compare
35c9b91
to
5eef9b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit then r=me
Apply suggestions from code review Co-authored-by: David Wood <[email protected]>
5eef9b1
to
e49d10d
Compare
@bors r+ |
first move on a nested span_label trying not to be smart this time.
first move on a nested span_label trying not to be smart this time.
first move on a nested span_label trying not to be smart this time.
…earth Rollup of 7 pull requests Successful merges: - rust-lang#100508 (avoid making substs of type aliases late bound when used as fn args) - rust-lang#101381 (Test that target feature mix up with homogeneous floats is sound) - rust-lang#103353 (Fix Access Violation when using lld & ThinLTO on windows-msvc) - rust-lang#103521 (Avoid possible infinite loop when next_point reaching the end of file) - rust-lang#103559 (first move on a nested span_label) - rust-lang#103778 (Update several crates for improved support of the new targets) - rust-lang#103827 (Properly remap and check for substs compatibility in `confirm_impl_trait_in_trait_candidate`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Migrate diagnostics in `rustc_borrowck` sorry for making a new PR, [rust-lang#103559](rust-lang#103559) and [rust-lang#103960](rust-lang#103960). I am crawling, joyfully.
trying not to be smart this time.