Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn newer available version of the x tool #104552
warn newer available version of the x tool #104552
Changes from 14 commits
c495558
b2cd337
b9b33d9
a917308
7fe2f73
02173f6
430ea8d
f50ad6c
5e67ce6
e94354e
d7cac97
e62258e
9aebb1e
e9ca663
376dd8a
85f649f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know this will be run from the root of the rust-lang/rust checkout?
I tested this by being in some random directory (inside the project) & it did use the root, but can we count on that or should the directory be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test by running
../../../x.py test tidy
fromsrc/tools/x
, which isn't in the workspace. If that works, andrust/x.py test tidy
works (from outside the source directory), this is fine :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err sorry - actually can you use
cargo_metadata
, like inrust/src/tools/tidy/src/deps.rs
Lines 347 to 354 in e9ca663
root
as an argument which avoids this question altogether.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running both of the above commands didn't end up working for me, even with the new change to use
cargo_metadata
.I end up getting tidy errors for autogenerated files in the build directory... This seems like a separate issue though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah that's from when I asked you to test
../../../x test tidy
, sorry about that 😅rm -rf src/tools/x/build
will make the errors go away (although I've been wanting to get tidy to ignore untracked files for a while; but that's a separate PR.)