Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make check on win32 #10472

Merged
merged 5 commits into from
Nov 14, 2013
Merged

Fix make check on win32 #10472

merged 5 commits into from
Nov 14, 2013

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented Nov 14, 2013

Closes #10452.

@alexcrichton
Copy link
Member

@klutzy and I talked about this offline. The signal difference is purely because windows doesn't really have signals at all, and I think that's fine. I asked him to update the documentation of ExitSignal (if possible) and he's currently investigating another failure before this is r+'d

Rename {struct-update,fsu}-moves-and-copies, since win32
failed to run the test since UAC prevents any executable whose
name contaning "update". (rust-lang#10452)

Some tests related to rust-lang#9205 are expected to fail on gcc 4.8,
so they are marked as `xfail-win32` instead of `xfail-fast`.

Some tests using `extra::tempfile` fail on win32 due to rust-lang#10462.
Mark them as `xfail-win32`.
sha1, version, util tests are still alive and they pass on win32.
bors added a commit that referenced this pull request Nov 14, 2013
@bors bors closed this Nov 14, 2013
@bors bors merged commit 1758585 into rust-lang:master Nov 14, 2013
@klutzy klutzy deleted the cleanup-xfail branch December 4, 2013 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make check broken on windows
3 participants