Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a commit_if_ok call to probe #105292

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Change a commit_if_ok call to probe #105292

merged 5 commits into from
Jan 9, 2023

Commits on Jan 9, 2023

  1. Change commit_if_ok to probe

    @JulianKnodt
    JulianKnodt committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    abe040d View commit details
    Browse the repository at this point in the history

  2. Change based on comments 

    Instead of just switching to a probe, check for different matches, and see how many there are.
If one, unify it, otherwise return true and let it be unified later.
    @JulianKnodt
    JulianKnodt committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    77b6137 View commit details
    Browse the repository at this point in the history

  3. Set !const_evaluatable if ambig. and not inferred 

    This prevents an ICE due to a value not actually being evaluatable later.
    @JulianKnodt
    JulianKnodt committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    b79a9a0 View commit details
    Browse the repository at this point in the history

  4. Check for duplicates

    @JulianKnodt
    JulianKnodt committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    7c5cb73 View commit details
    Browse the repository at this point in the history

  5. Clean up 

    Simplify match statement

Add multiple tests
- 1 test for checking `N + 1 + 1` does not unify with `N+1`
- 2 tests for checking that a function that uses two parameters only returns the parameter that
  is actually used.
- Check exact repeat predicates
    @JulianKnodt
    JulianKnodt committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    21c5ffe View commit details
    Browse the repository at this point in the history