Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ICE by accounting for missing type #105340

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Avoid ICE by accounting for missing type #105340

merged 1 commit into from
Dec 6, 2022
+131 −1

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 6, 2022

Fix #105330

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2022
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit 19f2e59ed5bda4fb3658b78950fca28ddc54d1ad has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@compiler-errors
Copy link
Member

@bors r- test failed, r=me after it's fixed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2022
@estebank
Copy link
Contributor Author

estebank commented Dec 6, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit 9c9dc60a195caf5cc519955e4058509ff8a3171a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2022
@compiler-errors
Copy link
Member

@bors r-

Now the file doesn't have a newline haha

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2022
@estebank
Copy link
Contributor Author

estebank commented Dec 6, 2022

VSCode is gaslighting me

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor Author

estebank commented Dec 6, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit eff7645 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 6, 2022
@matthiaskrgr
Rollup merge of rust-lang#105340 - estebank:ice-ice-baby, r=compiler-…
96888b9 
…errors

Avoid ICE by accounting for missing type

Fix rust-lang#105330
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
@bors
Auto merge of rust-lang#105365 - matthiaskrgr:rollup-g0mrrt7, r=matth…
b685242 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#104439 (Add prototype to generate `COPYRIGHT` from REUSE metadata)
 - rust-lang#105005 (On E0195 point at where clause lifetime bounds)
 - rust-lang#105098 (propagate the error from parsing enum variant to the parser and emit out)
 - rust-lang#105243 (remove no-op 'let _ = ')
 - rust-lang#105254 (Recurse into nested impl-trait when computing variance.)
 - rust-lang#105287 (Synthesize substitutions for bad auto traits in dyn types)
 - rust-lang#105310 (Be more careful about unresolved exprs in suggestion)
 - rust-lang#105318 (Make `get_impl_future_output_ty` work with AFIT)
 - rust-lang#105339 (support `ConstKind::Expr` in `is_const_evaluatable` and `WfPredicates::compute`)
 - rust-lang#105340 (Avoid ICE by accounting for missing type)
 - rust-lang#105342 (Make `note_obligation_cause_code`  take a `impl ToPredicate` for predicate)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07fd808 into rust-lang:master Dec 6, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE: None in compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:
5 participants
@estebank @rustbot @compiler-errors @bors @rust-log-analyzer