Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backport clippy stack overflow fix #106326

Merged
merged 1 commit into from
Dec 31, 2022
Merged

[beta] backport clippy stack overflow fix #106326

merged 1 commit into from
Dec 31, 2022

Conversation

matthiaskrgr
Copy link
Member

Backports rust-lang/rust-clippy#10086 to the beta branch where the bug is still present.

I just cherry-picked the commit.

cc @rust-lang/clippy

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2022
flip1995
flip1995 approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had this on my to-do list for next week.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Dec 31, 2022

📌 Commit 67745d4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@bors
Copy link
Contributor

bors commented Dec 31, 2022

⌛ Testing commit 67745d4 with merge 51b0345...

@bors
Copy link
Contributor

bors commented Dec 31, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 51b0345 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2022
@bors bors merged commit 51b0345 into rust-lang:beta Dec 31, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @rustbot @Mark-Simulacrum @bors @flip1995 @nbdd0121