Suggest making private tuple struct field public #106579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Jan 8, 2023
Comment on lines
+884
to
+887
| /// Span of the privacy modifier in fields of an item `DefId` accessible with dot syntax. | ||
| /// Used for hints during error reporting. | ||
| field_visibility_spans: FxHashMap<DefId, Vec<Span>>, | ||
|
|
There was a problem hiding this comment.
Would it make sense to extend and reuse the field_names field for this?
There was a problem hiding this comment.
field_names only had the Symbol and I wasn't sure if there was any place that relied on it being always a Vec, causing perf impact if needing to map/collect it every time. But yes, we could do that :)
There was a problem hiding this comment.
The only difference I see is that this approach will only store the privacy span vec for tuple structs and nothing else.
Noratrieb
reviewed
Jan 10, 2023
estebank
force-pushed
the
issue-52144
branch
2 times, most recently
from
a6c6886
to
9369bfa
Compare
* Account for `struct S(pub(super)Ty);` in suggestion * Suggest changing field visibility in E0603 too
|
@bors r+ |
bors
added
S-waiting-on-bors
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Jan 12, 2023
Suggest making private tuple struct field public Fix rust-lang#52144.
This was referenced Jan 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#105806 (Support eager subdiagnostics again) - rust-lang#106322 (Handle inference variables in `CollectAllMismatches` correctly) - rust-lang#106579 (Suggest making private tuple struct field public) - rust-lang#106714 (remove unreachable error code `E0490`) - rust-lang#106751 (Fix rendering 'const' in header for intrinsics) - rust-lang#106761 (Add `WaffleLapkin` to compiler reviewers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52144.