Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added const-generic ui test case for issue #106419 #107076

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Added const-generic ui test case for issue #106419 #107076

merged 1 commit into from
Jan 20, 2023

Conversation

megakorre
Copy link
Contributor

This PR adds a test case for #106419 which has been fixed in master by #105292

I also ran the test on f769d34 (the commit before #105292 was merged)
and it did fail there with the following output.

--- stderr -------------------------------
error[E0308]: mismatched types
  --> /home/patrikk/src/rust/src/test/ui/const-generics/issue-106419-struct-with-multiple-const-params.rs:5:10
   |
LL | #[derive(Clone)]
   |          ^^^^^
   |          |
   |          expected `A`, found `B`
   |          expected `Bar<A, B>` because of return type
   |
   = note: expected struct `Bar<A, _>`
              found struct `Bar<B, _>`
   = note: this error originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
------------------------------------------

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit 8657cb8 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@compiler-errors
Copy link
Member

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
@bors
Auto merge of rust-lang#107105 - matthiaskrgr:rollup-rkz9t7r, r=matth…
04a41f8 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106783 (Recover labels written as identifiers)
 - rust-lang#106973 (Don't treat closures from other crates as local)
 - rust-lang#106979 (Document how to get the type of a default associated type)
 - rust-lang#107053 (signal update string representation for haiku.)
 - rust-lang#107058 (Recognise double-equals homoglyph)
 - rust-lang#107067 (Custom MIR: Support storage statements)
 - rust-lang#107076 (Added const-generic ui test case for issue rust-lang#106419)
 - rust-lang#107091 (Fix broken format strings in `infer.ftl`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75655a9 into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@megakorre @rustbot @compiler-errors @bors