Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test for -Zdrop-tracking-mir #107438

Closed
wants to merge 2 commits into from

Conversation

cjgillot
Copy link
Contributor

r? @ghost

…, r=compiler-errors"

This reverts commit bcb064a, reversing
changes made to 9f82651.
…ess, r=oli-obk"

This reverts commit 6cd6bad, reversing
changes made to 7d4df2d.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 29, 2023
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2023
@bors
Copy link
Contributor

bors commented Jan 29, 2023

⌛ Trying commit 16f39c5 with merge 9250647a32081efc64f9e4227e08a5aaf86bc899...

@bors
Copy link
Contributor

bors commented Jan 29, 2023

☀️ Try build successful - checks-actions
Build commit: 9250647a32081efc64f9e4227e08a5aaf86bc899 (9250647a32081efc64f9e4227e08a5aaf86bc899)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9250647a32081efc64f9e4227e08a5aaf86bc899): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
-0.6% [-0.8%, -0.5%] 12
Improvements ✅
(secondary)
-0.7% [-1.1%, -0.3%] 9
All ❌✅ (primary) -0.6% [-0.8%, 0.4%] 13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [1.2%, 4.4%] 2
Improvements ✅
(primary)
-1.5% [-2.3%, -0.7%] 2
Improvements ✅
(secondary)
-1.6% [-2.4%, -0.9%] 3
All ❌✅ (primary) -1.5% [-2.3%, -0.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2023
@cjgillot cjgillot closed this Jan 31, 2023
@cjgillot cjgillot deleted the generator-perf branch January 31, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants