Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment on Allocator trait #107916

Merged
merged 1 commit into from
May 30, 2023
Merged

fix comment on Allocator trait #107916

merged 1 commit into from
May 30, 2023

Conversation

reez12g
Copy link
Contributor

@reez12g reez12g commented Feb 11, 2023

fixes #107040

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 11, 2023
@scottmcm
Copy link
Member

Since this is still marked draft, I'll assume
@rustbot author

(Please comment with @rustbot ready when you've undrafted it and think it's ready for review.)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2023
@reez12g
Copy link
Contributor Author

reez12g commented Feb 12, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2023
@reez12g reez12g marked this pull request as ready for review February 12, 2023 02:56
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@scottmcm
Copy link
Member

r? Amanieu
(as a legal reviewer from wg-allocators)

@rustbot rustbot assigned Amanieu and unassigned scottmcm Feb 16, 2023
@rust-lang rust-lang deleted a comment from rustbot Feb 16, 2023
@rust-lang rust-lang deleted a comment from rustbot Feb 16, 2023
@Amanieu
Copy link
Member

Amanieu commented Feb 19, 2023

I think it would be clearer to just say that block must remain valid until they are deallocated or all clones of the allocator are dropped.

@bors
Copy link
Contributor

bors commented Mar 26, 2023

☔ The latest upstream changes (presumably #105096) made this pull request unmergeable. Please resolve the merge conflicts.

@ChrisDenton
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2023
@Dylan-DPC
Copy link
Member

@reez12g any updates on this?

@reez12g
Copy link
Contributor Author

reez12g commented May 20, 2023

Sorry for the delay in responding. Conflicts have been resolved.

@Amanieu
Copy link
Member

Amanieu commented May 26, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 26, 2023

📌 Commit 5a3a65e1cc1dbc86efce75d6ad8d33cac22348a4 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2023
@klensy
Copy link
Contributor

klensy commented May 26, 2023

Should be squashed https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy 5a3a65e

@Amanieu
Copy link
Member

Amanieu commented May 26, 2023

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2023
@reez12g
Copy link
Contributor Author

reez12g commented May 30, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2023
@Amanieu
Copy link
Member

Amanieu commented May 30, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 30, 2023

📌 Commit 000cd9b has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 30, 2023
@Noratrieb
Rollup merge of rust-lang#107916 - reez12g:issue-107040, r=Amanieu
5da322f 
fix comment on Allocator trait

fixes rust-lang#107040
@Noratrieb Noratrieb mentioned this pull request May 30, 2023
Closed
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 30, 2023
@Noratrieb
Rollup merge of rust-lang#107916 - reez12g:issue-107040, r=Amanieu
39ed4e2 
fix comment on Allocator trait

fixes rust-lang#107040
This was referenced May 30, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 30, 2023
@bors
Auto merge of rust-lang#112102 - Nilstrieb:rollup-ivu1hmc, r=Nilstrieb
a9251b6 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#107916 (fix comment on Allocator trait)
 - rust-lang#111543 (Uplift `clippy::invalid_utf8_in_unchecked` lint)
 - rust-lang#111872 (fix: dedup `static_candidates` before report)
 - rust-lang#111955 (bootstrap: Various Step refactors)
 - rust-lang#112060 (`EarlyBinder::new` -> `EarlyBinder::bind`)
 - rust-lang#112064 (Migrate GUI colors test to original CSS color format)
 - rust-lang#112100 (Don't typecheck recovered method call from suggestion)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 18c9baf into rust-lang:master May 30, 2023
@rustbot rustbot added this to the 1.72.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

Safety comment on Allocator trait likely incorrect
8 participants
@reez12g @rustbot @scottmcm @Amanieu @bors @ChrisDenton @Dylan-DPC @klensy