Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: hide reference methods in search index #108146

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Feb 16, 2023

They're hidden in the HTML, so it makes no sense in the search engine for reference::next or reference::shrink to be shown.

https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/What.20is.20.60reference.3A.3Ashrink.60.3F

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 16, 2023
@notriddle notriddle force-pushed the notriddle/rustdoc-search-reference branch from a283959 to d6249bb Compare February 17, 2023 00:19
@notriddle notriddle changed the title rustdoc: hide reference methods in search index when not in HTML rustdoc: hide reference methods in search index Feb 17, 2023
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 18, 2023

📌 Commit 0e3ae60 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#104659 (reflow the stack size story)
 - rust-lang#106933 (Update documentation of select_nth_unstable and select_nth_unstable_by to state O(n^2) complexity)
 - rust-lang#107783 (rustdoc: simplify DOM for `.item-table`)
 - rust-lang#107951 (resolve: Fix doc links referring to other crates when documenting proc macro crates directly)
 - rust-lang#108130 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108146 (rustdoc: hide `reference` methods in search index)
 - rust-lang#108189 (Fix some more `non_lifetime_binders` stuff with higher-ranked trait bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 636679e into rust-lang:master Feb 19, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 19, 2023
@notriddle notriddle deleted the notriddle/rustdoc-search-reference branch February 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants