Implement read_buf for a few more types #108326

tmiasko · 2023-02-21T22:17:53Z

Implement read_buf for TcpStream, Stdin, StdinLock, ChildStdout,
ChildStderr (and internally for AnonPipe, Handle, Socket), so
that it skips buffer initialization.

The other provided methods like read_to_string and read_to_end are
implemented in terms of read_buf and so benefit from the optimization
as well.

This commit also implements read_vectored and is_read_vectored where
applicable.

rustbot · 2023-02-21T22:18:01Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-02-21T22:20:15Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

thomcc · 2023-02-22T00:15:16Z

Does this change stable API? It probably should have an ACP regardless...

tmiasko · 2023-02-22T00:26:10Z

There are no changes in public API. It only optimizes the implementation of read_buf (the provided implementation initializes the buffer completely and delegates to read).

thomcc · 2023-02-22T00:27:22Z

Oh right, of course. Sorry, I'll take a look later.

thomcc · 2023-02-26T19:39:56Z

Yeah these seem fine. I don't think it's worth blocking rollup since I doubt these types are used much in the compiler.

@bors r+

bors · 2023-02-26T19:39:58Z

📌 Commit 8ffb6af has been approved by thomcc

It is now in the queue for this repository.

Implement read_buf for a few more types Implement read_buf for TcpStream, Stdin, StdinLock, ChildStdout, ChildStderr (and internally for AnonPipe, Handle, Socket), so that it skips buffer initialization. The other provided methods like read_to_string and read_to_end are implemented in terms of read_buf and so benefit from the optimization as well. This commit also implements read_vectored and is_read_vectored where applicable.

compiler-errors · 2023-02-27T01:18:29Z

Failed in a rollup:

#108509 (comment)

@bors r-

thomcc · 2023-03-21T04:55:33Z

@bors r+

bors · 2023-03-21T04:55:35Z

📌 Commit defa245 has been approved by thomcc

It is now in the queue for this repository.

bors · 2023-03-21T11:26:50Z

⌛ Testing commit defa245 with merge 571328f5d7d4561541e1c5af0884a29b3adbbff1...

bors · 2023-03-21T11:44:56Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-03-21T11:46:57Z

The job i686-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2616/3021] Linking CXX static library lib\libLLVMWebAssemblyDisassembler.a
[2617/3021] Linking CXX static library lib\libLLVMPowerPCCodeGen.a
[2618/3021] Linking CXX static library lib\libLLVMSystemZCodeGen.a
[2619/3021] Linking CXX static library lib\libLLVMAVRCodeGen.a
FAILED: lib/libLLVMAVRCodeGen.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMAVRCodeGen.a && C:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMAVRCodeGen.a  lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRAsmPrinter.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRExpandPseudoInsts.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRFrameLowering.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRInstrInfo.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRISelDAGToDAG.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRISelLowering.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRMCInstLower.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRRegisterInfo.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRShiftExpand.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRSubtarget.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRTargetMachine.cpp.obj lib/Target/AVR/CMakeFiles/LLVMAVRCodeGen.dir/AVRTargetObjectFile.cpp.obj && C:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMAVRCodeGen.a && cd ."
C:\a\rust\rust\mingw32\bin\ranlib.exe: could not create temporary file whilst writing archive: no more archived files
[2620/3021] Linking CXX static library lib\libLLVMWebAssemblyCodeGen.a
[2621/3021] Linking CXX static library lib\libLLVMM68kCodeGen.a
[2622/3021] Linking CXX static library lib\libLLVMX86CodeGen.a
[2623/3021] Linking CXX executable bin\llvm-profdata.exe
[2623/3021] Linking CXX executable bin\llvm-profdata.exe
[2624/3021] Building CXX object tools/llc/CMakeFiles/llc.dir/llc.cpp.obj
[2625/3021] Building CXX object tools/lli/CMakeFiles/lli.dir/lli.cpp.obj
[2626/3021] Linking CXX static library lib\libLLVMPasses.a
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1cd66030c949c28d\cmake-0.1.48\src\lib.rs:975:5
 finished in 299.801 seconds
Build completed unsuccessfully in 0:06:13
Build completed unsuccessfully in 0:06:13
make: *** [Makefile:80: ci-mingw-subset-2] Error 1

tmiasko · 2023-03-21T11:53:47Z

@bors retry #108227

Noratrieb · 2023-03-21T11:59:38Z

The queue is pretty full, let's try rolling it up anyways so the rollup=always PRs can use the CI time from this
@bors rollup=iffy

Rollup of 10 pull requests Successful merges: - rust-lang#106434 (Document `Iterator::sum/product` for Option/Result) - rust-lang#108326 (Implement read_buf for a few more types) - rust-lang#108842 (Enforce non-lifetime-binders in supertrait preds are not object safe) - rust-lang#108896 (new solver: make all goal evaluation able to be automatically rerun ) - rust-lang#109124 (Add `dist.compression-profile` option to control compression speed) - rust-lang#109240 (Walk un-shifted nested `impl Trait` in trait when setting up default trait method assumptions) - rust-lang#109385 (fix typo) - rust-lang#109386 (add myself to mailmap) - rust-lang#109390 (Custom MIR: Support aggregate expressions) - rust-lang#109408 (not *all* retags might be explicit in Runtime MIR) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2023-03-21T14:33:01Z

⌛ Testing commit defa245 with merge a01b4cc...

In principle, this PR extends rust-lang#108326 for RustyHermit. Signed-off-by: Stefan Lankes <[email protected]>

Implement read_buf for RustHermit In principle, this PR extends rust-lang#108326 for RustyHermit.

…ad-buf, r=cuviper kmc-solid: Implement `Socket::read_buf` Follow-up to rust-lang#108326. Implements `Socket::read_buf` for the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets.

In principle, this PR extends rust-lang/rust#108326 for RustyHermit. Signed-off-by: Stefan Lankes <[email protected]>

Implement read_buf for RustHermit In principle, this PR extends rust-lang/rust#108326 for RustyHermit.

rustbot assigned thomcc Feb 21, 2023

tmiasko marked this pull request as ready for review February 21, 2023 22:20

tmiasko force-pushed the read-buf branch 2 times, most recently from b19428f to 94a1cc0 Compare February 21, 2023 22:24

This comment has been minimized.

Sign in to view

tmiasko force-pushed the read-buf branch 2 times, most recently from 8877d4b to 58fb78b Compare February 21, 2023 22:50

tmiasko force-pushed the read-buf branch from 58fb78b to 8ffb6af Compare February 22, 2023 21:10

tmiasko mentioned this pull request Feb 22, 2023

Use custom implementation of read_buf in Read for &'a FileDesc #108235

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023

matthiaskrgr mentioned this pull request Feb 26, 2023

Rollup of 9 pull requests #108509

Closed

compiler-errors mentioned this pull request Feb 26, 2023

Rollup of 6 pull requests #108511

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2023

Noratrieb mentioned this pull request Mar 21, 2023

Rollup of 10 pull requests #109442

Merged

bors merged commit 82dc127 into rust-lang:master Mar 21, 2023

rustbot added this to the 1.70.0 milestone Mar 21, 2023

tmiasko deleted the read-buf branch March 21, 2023 14:51

stlankes mentioned this pull request Mar 29, 2023

Implement read_buf for RustHermit #109722

Merged

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2023

Implement read_buf for RustHermit

a9aaf3f

In principle, this PR extends rust-lang#108326 for RustyHermit. Signed-off-by: Stefan Lankes <[email protected]>

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2023

Rollup merge of rust-lang#109722 - hermitcore:read, r=Mark-Simulacrum

e79ef4d

Implement read_buf for RustHermit In principle, this PR extends rust-lang#108326 for RustyHermit.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 3, 2023

Rollup merge of rust-lang#109722 - hermitcore:read, r=Mark-Simulacrum

f2f5efc

Implement read_buf for RustHermit In principle, this PR extends rust-lang#108326 for RustyHermit.

kawadakk mentioned this pull request Apr 11, 2023

kmc-solid: Implement Socket::read_buf #110173

Merged

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jun 1, 2023

Implement read_buf for RustHermit

e9e0a8b

In principle, this PR extends rust-lang/rust#108326 for RustyHermit. Signed-off-by: Stefan Lankes <[email protected]>

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jun 1, 2023

Rollup merge of #109722 - hermitcore:read, r=Mark-Simulacrum

c231dc4

Implement read_buf for RustHermit In principle, this PR extends rust-lang/rust#108326 for RustyHermit.

dtolnay mentioned this pull request Feb 26, 2024

Add Read Impl for &Stdin #99153

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement read_buf for a few more types #108326

Implement read_buf for a few more types #108326

tmiasko commented Feb 21, 2023

rustbot commented Feb 21, 2023

rustbot commented Feb 21, 2023

This comment has been minimized.

thomcc commented Feb 22, 2023

tmiasko commented Feb 22, 2023

thomcc commented Feb 22, 2023

thomcc commented Feb 26, 2023

bors commented Feb 26, 2023

compiler-errors commented Feb 27, 2023

thomcc commented Mar 21, 2023

bors commented Mar 21, 2023

bors commented Mar 21, 2023

bors commented Mar 21, 2023

rust-log-analyzer commented Mar 21, 2023

tmiasko commented Mar 21, 2023

Noratrieb commented Mar 21, 2023

bors commented Mar 21, 2023

Implement read_buf for a few more types #108326

Implement read_buf for a few more types #108326

Conversation

tmiasko commented Feb 21, 2023

rustbot commented Feb 21, 2023

rustbot commented Feb 21, 2023

This comment has been minimized.

thomcc commented Feb 22, 2023

tmiasko commented Feb 22, 2023

thomcc commented Feb 22, 2023

thomcc commented Feb 26, 2023

bors commented Feb 26, 2023

compiler-errors commented Feb 27, 2023

thomcc commented Mar 21, 2023

bors commented Mar 21, 2023

bors commented Mar 21, 2023

bors commented Mar 21, 2023

rust-log-analyzer commented Mar 21, 2023

tmiasko commented Mar 21, 2023

Noratrieb commented Mar 21, 2023

bors commented Mar 21, 2023