Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hir-analysis: make where-clause-on-main diagnostic translatable #108373

Merged
merged 1 commit into from
Feb 23, 2023
Merged

hir-analysis: make where-clause-on-main diagnostic translatable #108373

merged 1 commit into from
Feb 23, 2023

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

Just sharing my thoughts -- I wonder, if you're planning on migrating some of the error diagnostics in rustc_hir_analysis (or any crate for that matter), it may be better to group more diagnostics into one bigger PR, rather than opening up many small PRs, just because it's easier for reviewers to review all of them in one pass.

Check out the tracking issue for diagnostics migration (#100717) for examples of bigger PRs that have been opened to migrate crates like this. Also, it may be worthwhile commenting on that issue if you plan to take on rustc_hir_analysis or another big crate, so someone else doesn't also get started on the same work.

@bors
Copy link
Contributor

bors commented Feb 23, 2023

📌 Commit ada4e94 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2023
@bors
Auto merge of rust-lang#108386 - matthiaskrgr:rollup-nojivk9, r=matth…
eb909d8 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108063 (Ban associated type bounds in bad positions)
 - rust-lang#108208 (Correctly handle aggregates in DataflowConstProp)
 - rust-lang#108218 (Windows: Quote more batch file arguments)
 - rust-lang#108349 (rustdoc: Prevent duplicated imports)
 - rust-lang#108350 (Use associated type bounds in some places in the compiler)
 - rust-lang#108358 (Add git config command to `.git-blame-ignore-revs`)
 - rust-lang#108373 (hir-analysis: make where-clause-on-main diagnostic translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 60014e4 into rust-lang:master Feb 23, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 23, 2023
@tshepang tshepang deleted the where-clause-on-main branch February 23, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @compiler-errors @bors @petrochenkov