Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rustc_hir_analysis to session diagnostic [Part One] #108434

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Migrate rustc_hir_analysis to session diagnostic [Part One] #108434

merged 1 commit into from
Feb 25, 2023

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Feb 24, 2023

Finishing lib.rs file
Updates #100717
r? @davidtwco

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2023
Noratrieb
Noratrieb approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? Nilstrieb
Looks great, thanks! Waiting for CI to complete, then I'll approve it

@rustbot rustbot assigned Noratrieb and unassigned davidtwco Feb 24, 2023
@Noratrieb
Copy link
Member

i was almost on time :D
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2023

📌 Commit 34966aa has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 24, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#108434 - obeis:hir-analysis-migrate-diagnos…
abdd7f8 
…tics, r=Nilstrieb

Migrate `rustc_hir_analysis` to session diagnostic [Part One]

Finishing `lib.rs` file
Updates rust-lang#100717
r? `@davidtwco`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 25, 2023
Merged
@Noratrieb Noratrieb mentioned this pull request Feb 25, 2023
Open
84 tasks
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2023
@bors
Auto merge of rust-lang#108450 - matthiaskrgr:rollup-rqvfgu3, r=matth…
31448ba 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108354 (Update `fuchsia-test-runner.py` and docs)
 - rust-lang#108404 (support `x fmt` for sub and outside of rust directories)
 - rust-lang#108407 (docs: use intra-doc links for `Vec::get(_mut)`)
 - rust-lang#108410 (rustdoc: avoid including `<li>` tags in item table short desc)
 - rust-lang#108412 (Fix GUI test navigation bug)
 - rust-lang#108433 (Wrap missing provider message correctly)
 - rust-lang#108434 (Migrate `rustc_hir_analysis` to session diagnostic [Part One])

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2aad179 into rust-lang:master Feb 25, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 25, 2023
@obeis obeis deleted the hir-analysis-migrate-diagnostics branch May 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@obeis @Noratrieb @bors @davidtwco @rustbot