Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider target_family as pal #108917

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Consider target_family as pal #108917

merged 1 commit into from
Mar 10, 2023

Conversation

Ayush1325
Copy link
Contributor

Currently, tidy does not consider code in target_family as platform-specific. This is erroneous and should be fixed.

r? @workingjubilee

Currently tidy does not consider code in target_family as
platform-specific. I think this is erroneous and should be fixed.

Signed-off-by: Ayush Singh <[email protected]>
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
@workingjubilee
Copy link
Member

Excellent!

I would like to see this exception removed but adding the proper tidy check is certainly "step one" here.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2023

📌 Commit d75dae2 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106915 (Only load one CSS theme by default)
 - rust-lang#108294 (Place binder correctly for arbitrary trait bound suggestion)
 - rust-lang#108778 (x fmt: Don't print all modified files if there's more than 10)
 - rust-lang#108854 (feat/refactor: improve errors in case of ident with number at start)
 - rust-lang#108870 (Fix invalid inlining of reexport of reexport of private item)
 - rust-lang#108917 (Consider target_family as pal)
 - rust-lang#108922 (Add auto notification for changes to stable mir)
 - rust-lang#108929 (Fix typo in span_map.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 972ea7f into rust-lang:master Mar 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 10, 2023
@Ayush1325 Ayush1325 deleted the tidy-improve branch March 10, 2023 12:03
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2023
…bilee

Move __thread_local_inner to sys

Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around.

This probably will need a rebase once rust-lang#108917 is merged

r? `@workingjubilee`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2023
…bilee

Move __thread_local_inner to sys

Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around.

This probably will need a rebase once rust-lang#108917 is merged

r? ``@workingjubilee``
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jun 1, 2023
Move __thread_local_inner to sys

Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around.

This probably will need a rebase once rust-lang/rust#108917 is merged

r? ``@workingjubilee``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants