-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a context for making things #109186
Add a context for making things #109186
Conversation
Some changes occured in cc @BoxyUwU Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred in engine.rs, potentially modifying the public API of Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Huh -- not sure if I like this better than just normalizing all the method names (make sure they start with |
I do like it 😃 But it does seem affect enough code to warrant an MCP (and then compiler-errors and I can fight it out in a zulip thread 😃). The MCP should probably be more about the general idea, as it seems applicable to other things, too |
This comment has been minimized.
This comment has been minimized.
2f0cd15
to
82fd36f
Compare
Co-authored-by: nils <[email protected]>
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #108282) made this pull request unmergeable. Please resolve the merge conflicts. |
|
We could use const generics of |
@oli-obk @compiler-errors I've opened an MCP, now fight rust-lang/compiler-team#603 |
Closed as the MCP was not accepted. |
r? @oli-obk
cc @nnethercote (I've touched these files recently)
TL;DR: replace
tcx.mk_something()
withtcx.mk().something()
in order to improve documentation (less stuff in theTyCtxt
impls)Future work:
mk_*
methods fromTyCtxtAt
maybeMkCtxt
's methodsmk_
or have_mk_
in the middleI'm not 100% sure this is a good idea, but generally de-bloating
TyCtxt
seems good.