…ype"

This makes it possible to make the normalization of the error message
more precise, allowing us to not normalize all notes away.

We can easily pass in the source map.

Rename `with_source_map` as `set_source_map`. Because `with` functions
(e.g. `with_session_globals`, `scoped_tls::ScopedKey::with`) are for
*getting* a value for the duration of a closure, and `set` functions
(e.g. `set_session_globals_then` `scoped_tls::ScopedKey::with`) are for
*setting* a value for the duration of a closure.

Also fix up the comment, which is wrong:
- The bit about `TyCtxt` is wrong.
- `span_debug1` doesn't exist any more.
- There's only one level of fallback, not two.

(This is effectively a follow-up to the changes in rust-lang#93936.)

Also add a comment explaining that `SessionGlobals::source_map` should
only be used when absolutely necessary.

…ion-ambiguous-intra-doc2, r=oli-obk,notriddle

rustdoc: Fix invalid suggestions on ambiguous intra doc links v2

Fixes rust-lang#108653.

This is another approach to fixing the same issue. This time, we keep the computed information around instead of re-computing it.

Strangely enough, the order for ambiguities seem to have been changed. Not an issue but it creates a lot of diff...

So which version do you prefer?

r? `@notriddle`

…error, r=notriddle

Move `doc(primitive)` future incompat warning to `invalid_doc_attributes`

Fixes rust-lang#88070.

It's been a while since this was turned into a "future incompatible lint" so I think we can now turn it into a hard error without problem.

r? `@jyn514`

…avidtwco

Fix subslice capture in closure

Fixes rust-lang#109298 by refining captures in the same way for Subslices and Indexes. The comment `// we never capture this` seems to have been inaccurate, as changing it to an assert causes many test failures

`@rustbot` label +A-closures

fluent_messages macro: don't emit the OS error in a note

This makes it possible to make the normalization of the error message precise, allowing us to not normalize all notes away. See rust-lang#109700 (comment)

…=bjorn3

Source map cleanups

r? `@bjorn3`

…, r=notriddle

rustdoc: Add GUI test for jump to collapsed item

Part of rust-lang#66181.

I updated `browser-ui-test` version because I needed to add a new command `property`: GuillaumeGomez/browser-UI-test#452.

r? `@notriddle`

…camelid

rustdoc-search: update docs for comma in `?` help popover