Rollup of 9 pull requests #109941

compiler-errors · 2023-04-04T16:27:48Z

Successful merges:

Pull some tuple variant fields out into their own struct #109723 (Pull some tuple variant fields out into their own struct)
Fix non_exhaustive_omitted_patterns lint span #109838 (Fix non_exhaustive_omitted_patterns lint span)
Enforce VarDebugInfo::Place in MIR validation. #109901 (Enforce VarDebugInfo::Place in MIR validation.)
Doc-comment IndexVec::from_elem and use it in a few more places #109913 (Doc-comment IndexVec::from_elem and use it in a few more places)
Emit feature error for parenthesized generics in associated type bounds #109914 (Emit feature error for parenthesized generics in associated type bounds)
rustdoc: escape GAT args in more cases #109919 (rustdoc: escape GAT args in more cases)
Don't collect return-position impl traits for documentation #109937 (Don't collect return-position impl traits for documentation)
Move a const-prop-lint specific hack from mir interpret to const-prop-lint and make it fallible #109938 (Move a const-prop-lint specific hack from mir interpret to const-prop-lint and make it fallible)
Add regression test for #93911 #109940 (Add regression test for Incorrect "use of undeclared lifetime name" error with nested async functions #93911)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…-lint and make it fallible

Signed-off-by: Yuki Okushi <[email protected]>

Pull some tuple variant fields out into their own struct This is groundwork for adding more fields to those new structs, but I believe the change to be useful on its own. r? `@Nilstrieb` but feel free to reroll for `compiler`

…ilstrieb Fix `non_exhaustive_omitted_patterns` lint span Fixes rust-lang#109837 `DUMMY_SP` was being passed as the span in many cases where we have a span available to use. This meant that the location of the violating pattern wasn't shown, or the list of un-covered variants r? `@Nilstrieb`

…aber Enforce VarDebugInfo::Place in MIR validation.

Doc-comment `IndexVec::from_elem` and use it in a few more places Since this PR is a reply to rust-lang#109819 (comment), r? ``@WaffleLapkin``

…oli-obk Emit feature error for parenthesized generics in associated type bounds We don't actually do AST->HIR lowering with some `-Zunpretty` flags, so it's not correct to just delay a bug instead of emitting a feature error. Some diagnostics regressed because of the new errors, but oh well. 🤷 Fixes rust-lang#109898

…=notriddle rustdoc: escape GAT args in more cases Fixes rust-lang#109488. Previously we printed the *un*escaped form of GAT arguments not only when `f.alternate()` was true but *also* when we failed to compute the URL of the trait associated with the type projection, i.e. when `href(…)` returned an `Err(_)`. In this PR the argument printing logic is entirely separate from the link resolution code above as it should be. Further, we now only try to compute the URL if the HTML format was requested with `!f.alternate()`. Before, we would sometimes compute the `href` only to throw it away later.

…be-documented, r=GuillaumeGomez Don't collect return-position impl traits for documentation rust-lang#104889 modified the rustdoc ast collection step to use a HIR visitor, which more thoroughly walks the HIR tree. that means that we're going to encounter inner items (incl return-position impl traits and async fn opaque futures) that are not possible to document. FIxes (but does not close due to being a beta regression) rust-lang#109931 r? `@GuillaumeGomez`

Move a const-prop-lint specific hack from mir interpret to const-prop-lint and make it fallible fixes rust-lang#109743 This hack didn't need to live in the mir interpreter. For const-prop-lint it is entirely correct to avoid doing any const prop if normalization fails at this stage. Most likely we couldn't const propagate anything anyway, and if revealing was needed (so opaque types were involved), we wouldn't want to be too smart and leak the hidden type anyway.

…errors Add regression test for rust-lang#93911 r? `@compiler-errors` Closes rust-lang#93911

compiler-errors · 2023-04-04T16:28:37Z

@bors r+ rollup=never p=8

bors · 2023-04-04T16:28:39Z

📌 Commit 678d7c5 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-04-04T16:39:29Z

⌛ Testing commit 678d7c5 with merge 540a50d...

bors · 2023-04-04T18:55:48Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 540a50d to master...

rust-timer · 2023-04-04T18:58:23Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#109940	e5b0d600ba8c08da062816981c92e6142bd2cbb7
#109938	24342d43c635a2e45024528baa75589dac4b841c
#109937	289aac7726014985c4b24544ce9102d8abe4f822
#109919	308077c578281d8eba13f13f7de3fba795ee5a8a
#109914	a10e76ceb696cc641413e566db5769e7e0f76134
#109913	e45e7413e995030a2b80bf480062410932e81114
#109901	e5b058954d3cb2baac92e1628bca151fbcfa99ad
#109838	698f0cd5cbdb7c99e48d5d1fae49d30c38fed3b1
#109723	f12f4746443c2f2ed153a624d398955a79b46fa2

previous master: be8e5ba157

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-04T20:12:58Z

Finished benchmarking commit (540a50d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.4%, -0.3%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.0%, 3.5%]	3
Regressions ❌ (secondary)	1.7%	[1.1%, 3.4%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.0%, 3.5%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-4.7%, -0.7%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-4.7%, -0.7%]	10

clubby789 and others added 22 commits April 2, 2023 16:37

Fix non_exhaustive_omitted_patterns lint span

696f182

Enforce VarDebugInfo::Place in MIR validation.

a84909c

Emit feature error for parenthesized generics in associated type bounds

ab0b935

Doc-comment IndexVec::from_elem and use it in a few more places

5c3e5af

rustdoc: escape GAT args in more cases

6567bc9

rust-analyzer guided enum variant structification

b08a557

rust-analyzer guided tuple field to named field

e382877

Split out ast::ItemKind::Const into its own struct

ec74653

Move a const-prop-lint specific hack from mir interpret to const-prop…

b5d96d5

…-lint and make it fallible

box a bunch of large types

4bebdd7

Don't collect return-position impl traits for documentation

72ef85d

Rename ast::Static to ast::StaticItem to match ast::ConstItem

373807a

Add regression test for rust-lang#93911

1a8612e

Signed-off-by: Yuki Okushi <[email protected]>

Rollup merge of rust-lang#109901 - cjgillot:validate-debuginfo, r=b-n…

ed17b59

…aber Enforce VarDebugInfo::Place in MIR validation.

Rollup merge of rust-lang#109913 - scottmcm:index-slice, r=WaffleLapkin

5485a54

Doc-comment `IndexVec::from_elem` and use it in a few more places Since this PR is a reply to rust-lang#109819 (comment), r? ``@WaffleLapkin``

Rollup merge of rust-lang#109940 - JohnTitor:issue-93911, r=compiler-…

678d7c5

…errors Add regression test for rust-lang#93911 r? `@compiler-errors` Closes rust-lang#93911

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2023

bors merged commit 540a50d into rust-lang:master Apr 4, 2023

rustbot added this to the 1.70.0 milestone Apr 4, 2023

bors mentioned this pull request Apr 4, 2023

Introduce AliasKind::Inherent for inherent associated types #109410

Merged

compiler-errors deleted the rollup-5lsst2u branch August 11, 2023 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #109941

Rollup of 9 pull requests #109941

compiler-errors commented Apr 4, 2023

compiler-errors commented Apr 4, 2023

bors commented Apr 4, 2023

bors commented Apr 4, 2023

bors commented Apr 4, 2023

rust-timer commented Apr 4, 2023

rust-timer commented Apr 4, 2023

Rollup of 9 pull requests #109941

Rollup of 9 pull requests #109941

Conversation

compiler-errors commented Apr 4, 2023

compiler-errors commented Apr 4, 2023

bors commented Apr 4, 2023

bors commented Apr 4, 2023

bors commented Apr 4, 2023

rust-timer commented Apr 4, 2023

rust-timer commented Apr 4, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles