Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive String's PartialEq implementation #109980

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Derive String's PartialEq implementation #109980

merged 1 commit into from
Apr 6, 2023

Conversation

KamilaBorowska
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 5, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 5, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@compiler-errors
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2023
@bors
Copy link
Contributor

bors commented Apr 5, 2023

⌛ Trying commit 279f35c with merge dda42e1a423aee625eeebe3847cb0f6f06eb2bff...

@scottmcm scottmcm assigned scottmcm and unassigned Mark-Simulacrum Apr 5, 2023
@scottmcm
Copy link
Member

scottmcm commented Apr 5, 2023

r=me assuming perf is happy

@bors
Copy link
Contributor

bors commented Apr 5, 2023

☀️ Try build successful - checks-actions
Build commit: dda42e1a423aee625eeebe3847cb0f6f06eb2bff (dda42e1a423aee625eeebe3847cb0f6f06eb2bff)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dda42e1a423aee625eeebe3847cb0f6f06eb2bff): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 2.4% [1.9%, 3.0%] 2
Improvements ✅
(primary)		 -1.8% [-3.4%, -1.0%] 3
Improvements ✅
(secondary)		 -3.4% [-4.4%, -2.5%] 2
All ❌✅ (primary) -1.1% [-3.4%, 1.1%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2023
@scottmcm
Copy link
Member

scottmcm commented Apr 5, 2023

@bors r+ rollup=maybe

@bors
Copy link
Contributor

bors commented Apr 5, 2023

📌 Commit 279f35c has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 6, 2023
@Dylan-DPC
Rollup merge of rust-lang#109980 - xfix:derive-string-partialeq, r=sc…
0d14c2a 
…ottmcm

Derive String's PartialEq implementation
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 6, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#109980 - xfix:derive-string-partialeq, r=sc…
0ca7ecc 
…ottmcm

Derive String's PartialEq implementation
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 6, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2023
@bors
Auto merge of rust-lang#110012 - matthiaskrgr:rollup-sgmm5xv, r=matth…
de74dab 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109395 (Fix issue when there are multiple candidates for edit_distance_with_substrings)
 - rust-lang#109755 (Implement support for `GeneratorWitnessMIR` in new solver)
 - rust-lang#109782 (Don't leave a comma at the start of argument list when removing arguments)
 - rust-lang#109977 (rustdoc: avoid including line numbers in Google SERP snippets)
 - rust-lang#109980 (Derive String's PartialEq implementation)
 - rust-lang#109984 (Remove f32 & f64 from MemDecoder/MemEncoder)
 - rust-lang#110004 (add `dont_check_failure_status` option in the compiler test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dbc2941 into rust-lang:master Apr 6, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 6, 2023
@compiler-errors compiler-errors mentioned this pull request Oct 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@KamilaBorowska @rustbot @compiler-errors @rust-timer @bors @scottmcm @Mark-Simulacrum