Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #110311

Merged
merged 28 commits into from
Apr 14, 2023
Merged

Rollup of 9 pull requests #110311

merged 28 commits into from
Apr 14, 2023

Commits on Mar 16, 2023

  1. Clarify that RUST_MIN_STACK is internally cached

    For larger applications it's important that users set `RUST_MIN_STACK`
    at the start of their program because `min_stack` caches the value.
    Not doing so can lead to their `env::set_var` call surprisingly not having any effect.
    seanlinsley authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    54567ef View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Update mod.rs

    seanlinsley authored Mar 17, 2023
    Configuration menu
    Copy the full SHA
    6eef755 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. remove obsolete test

    TDecking authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    65c9c79 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Configuration menu
    Copy the full SHA
    171f541 View commit details
    Browse the repository at this point in the history
  2. remove issue-2718.rs test

    this test was added for rust 0.4 and doesn't test anything specific.
    The repro originally relied on extern functions which are now just
    ordinary methods. It's also a run pass test even though `main` has
    been commented out.
    lcnr committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    43e6f99 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Remove useless match.

    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    722e078 View commit details
    Browse the repository at this point in the history
  2. Make mk_bound_region closure more generic.

    This is necessary for the subsequent commits.
    nnethercote committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c18773a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e51b2d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80c4323 View commit details
    Browse the repository at this point in the history
  5. Cover edge cases for {f32, f64}.hypot() docs

    Re-phrase in a way that handles input values being either 0 or
    negative.
    jmaargh committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    cd868dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dcc51f1 View commit details
    Browse the repository at this point in the history
  7. make tcx.impl_subject return EarlyBinder, remove bound_impl_subject, …

    …rename usages of bound_impl_subject to impl_subject
    kylematsuda committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e2f5a5a View commit details
    Browse the repository at this point in the history
  8. Improve safe transmute error reporting

    This patch updates the error reporting when Safe Transmute is not
    possible between 2 types by including the reason.
    
    Also, fix some small bugs that occur when computing the `Answer` for
    transmutability.
    bryangarza committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    36febe1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8d5ee1a View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Configuration menu
    Copy the full SHA
    7dbd2e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f07c335 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b335c2d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    319c790 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c68c6c3 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#109225 - seanlinsley:patch-1, r=ChrisDenton

    Clarify that RUST_MIN_STACK may be internally cached
    
    For larger applications it's important that users set `RUST_MIN_STACK` at the start of their program because [`min_stack`](https://github.com/rust-lang/rust/blob/7d3e03666a93bd2b0f78b3933f9305832af771a5/library/std/src/sys_common/thread.rs) caches the value. Not doing so can lead to their `env::set_var` call surprisingly not having any effect.
    
    In my own testing `RUST_MIN_STACK` had no effect until I moved it to the top of `main()`. Hopefully this clarification in the docs will help others going forward.
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    ec08676 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#109800 - bryangarza:safe-transmute-improved…

    …-errors, r=compiler-errors
    
    Improve safe transmute error reporting
    
    This patch updates the error reporting when Safe Transmute is not possible between 2 types by including the reason.
    
    Also, fix some small bugs that occur when computing the `Answer` for transmutability.
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c6223e1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#110158 - TDecking:obsolete_test, r=ChrisDenton

    Remove obsolete test case
    
    This test case was supposed to cover issue rust-lang#31109 at some point.
    It never did anything, as the issue was still open at the time of its creation.
    When the issue was resolved, the `issue31109` test case was created,
    making the existence of this test pointless.
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    2e39e15 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#110180 - lcnr:canonicalize, r=compiler-errors

    don't uniquify regions when canonicalizing
    
    uniquifying causes a bunch of issues, most notably it causes `AliasEq(<?x as Trait<'a>>::Assoc, <?x as Trait<'a>>::Assoc)` to result in ambiguity because both `normalizes-to` paths result in ambiguity and substs equate should trivially succeed but doesn't because we uniquified `'a` to two different regions.
    
    I originally added uniquification to make it easier to deal with requirement 6 from the dev-guide: https://rustc-dev-guide.rust-lang.org/solve/trait-solving.html#requirements
    
    > ### 6. Trait solving must be (free) lifetime agnostic
    >
    > Trait solving during codegen should have the same result as during typeck. As we erase
    > all free regions during codegen we must not rely on them during typeck. A noteworthy example
    > is special behavior for `'static`.
    
    cc rust-lang/rustc-dev-guide#1671
    
    Relying on regions being identical may cause ICE during MIR typeck, but even without this PR we can end up relying on that as type inference vars can resolve to types which contain an identical region. Let's land this and deal with any ICE that crop up as we go. Will look at this issue again before stabilization.
    
    r? ```@compiler-errors```
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    44db7c3 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#110207 - compiler-errors:new-solver-unpin, …

    …r=lcnr
    
    Assemble `Unpin` candidates specially for generators in new solver
    
    Fixes compiler-errors/next-solver-hir-issues#16
    
    r? ``@lcnr``
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    69d7172 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#110276 - nnethercote:rm-BrAnon-Span, r=jack…

    …h726
    
    Remove all but one of the spans in `BoundRegionKind::BrAnon`
    
    There are only three places where `BoundRegionKind::BrAnon` uses `Some(span)` instead of `None`. Two of them are easy to remove, which this PR does.
    
    r? ```@jackh726```
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f3c6955 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#110279 - GuillaumeGomez:compiler-macro-deri…

    …ve, r=notriddle
    
    rustdoc: Correctly handle built-in compiler proc-macros as proc-macro and not macro
    
    Part of rust-lang#110111.
    
    There were actually one issue split in two parts:
     * Compiler built-in proc-macro were incorrectly considered as macros and not proc-macros.
     * Re-exports of compiler built-in proc-macros were considering them as macros.
    
    Both issues can be fixed by looking at the `MacroKind` variant instead of just relying on information extracted later on.
    
    r? ``@fmease``
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    35bd52e View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#110298 - jmaargh:jmaargh/hypot-docs-edge-ca…

    …ses, r=thomcc
    
    Cover edge cases for {f32, f64}.hypot() docs
    
    Fixes rust-lang#88944
    
    The Euclidean distance is a more general way to express what these functions do, and covers the edge cases of zero and negative inputs.
    
    Does not cover the case of non-normal input values (as the [POSIX docs](https://pubs.opengroup.org/onlinepubs/9699919799.2008edition/) do), but the docs for the rest of the functions in these modules do not address this, I assumed it was not desired.
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a7889d1 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#110299 - kylematsuda:earlybinder-impl-subje…

    …ct, r=compiler-errors
    
    Switch to `EarlyBinder` for `impl_subject` query
    
    Part of the work to finish rust-lang#105779.
    
    Several queries `X` have a `bound_X` variant that wraps the output in `EarlyBinder`. This adds `EarlyBinder` to the return type of the `impl_subject` query and removes `bound_impl_subject`.
    
    r? ```@lcnr```
    matthiaskrgr authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    610bc68 View commit details
    Browse the repository at this point in the history