-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #110463
Rollup of 6 pull requests #110463
Commits on Apr 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fca671b - Browse repository at this point
Copy the full SHA fca671bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e952a6 - Browse repository at this point
Copy the full SHA 2e952a6View commit details
Commits on Apr 16, 2023
-
Set git info env variables when building tools
This should fix issue rust-lang#107094.
Configuration menu - View commit details
-
Copy full SHA for 28d27fd - Browse repository at this point
Copy the full SHA 28d27fdView commit details -
Add needs-git-hash header to compiletest
This header can be used for tests which check the output of `--version --verbose` commands.
Configuration menu - View commit details
-
Copy full SHA for d535af3 - Browse repository at this point
Copy the full SHA d535af3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 135e620 - Browse repository at this point
Copy the full SHA 135e620View commit details -
Configuration menu - View commit details
-
Copy full SHA for 550df4d - Browse repository at this point
Copy the full SHA 550df4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfa8798 - Browse repository at this point
Copy the full SHA bfa8798View commit details -
Don't use
serde_json
to serialize a simple JSON objectThis avoids `rustc_data_structures` depending on `serde_json` which allows it to be compiled much earlier, unlocking most of rustc.
Configuration menu - View commit details
-
Copy full SHA for 7859a8e - Browse repository at this point
Copy the full SHA 7859a8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9a6e41 - Browse repository at this point
Copy the full SHA c9a6e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for abc0660 - Browse repository at this point
Copy the full SHA abc0660View commit details -
Add
rustc_fluent_macro
to decouple fluent fromrustc_macros
Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
Configuration menu - View commit details
-
Copy full SHA for ff04b6a - Browse repository at this point
Copy the full SHA ff04b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b981c2 - Browse repository at this point
Copy the full SHA 4b981c2View commit details
Commits on Apr 17, 2023
-
Add list of supported disambiguators and suffixes for intra-doc links…
… in the rustdoc book
Configuration menu - View commit details
-
Copy full SHA for a091fd2 - Browse repository at this point
Copy the full SHA a091fd2View commit details -
Add code comment to remind contributors to update rustdoc book if the…
…y update the disambiguators list
Configuration menu - View commit details
-
Copy full SHA for 1531c95 - Browse repository at this point
Copy the full SHA 1531c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6978147 - Browse repository at this point
Copy the full SHA 6978147View commit details -
Configuration menu - View commit details
-
Copy full SHA for b33d6ea - Browse repository at this point
Copy the full SHA b33d6eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ed1ef - Browse repository at this point
Copy the full SHA 78ed1efView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3d2a0a - Browse repository at this point
Copy the full SHA e3d2a0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b91a4e9 - Browse repository at this point
Copy the full SHA b91a4e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc07f57 - Browse repository at this point
Copy the full SHA bc07f57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e4f98a - Browse repository at this point
Copy the full SHA 1e4f98aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d218a02 - Browse repository at this point
Copy the full SHA d218a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 725537c - Browse repository at this point
Copy the full SHA 725537cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c93226d - Browse repository at this point
Copy the full SHA c93226dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 830fa9e - Browse repository at this point
Copy the full SHA 830fa9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de2a74 - Browse repository at this point
Copy the full SHA 6de2a74View commit details -
Configuration menu - View commit details
-
Copy full SHA for af46d60 - Browse repository at this point
Copy the full SHA af46d60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a763c9 - Browse repository at this point
Copy the full SHA 0a763c9View commit details -
Rollup merge of rust-lang#109507 - Amanieu:panic-oom-payload, r=david…
…twco Report allocation errors as panics OOM is now reported as a panic but with a custom payload type (`AllocErrorPanicPayload`) which holds the layout that was passed to `handle_alloc_error`. This should be review one commit at a time: - The first commit adds `AllocErrorPanicPayload` and changes allocation errors to always be reported as panics. - The second commit removes `#[alloc_error_handler]` and the `alloc_error_hook` API. ACP: rust-lang/libs-team#192 Closes rust-lang#51540 Closes rust-lang#51245
Configuration menu - View commit details
-
Copy full SHA for 5cd90ee - Browse repository at this point
Copy the full SHA 5cd90eeView commit details -
Rollup merge of rust-lang#109732 - Urgau:uplift_drop_forget_ref_lints…
…, r=davidtwco Uplift `clippy::{drop,forget}_{ref,copy}` lints This PR aims at uplifting the `clippy::drop_ref`, `clippy::drop_copy`, `clippy::forget_ref` and `clippy::forget_copy` lints. Those lints are/were declared in the correctness category of clippy because they lint on useless and most probably is not what the developer wanted. ## `drop_ref` and `forget_ref` The `drop_ref` and `forget_ref` lint checks for calls to `std::mem::drop` or `std::mem::forget` with a reference instead of an owned value. ### Example ```rust let mut lock_guard = mutex.lock(); std::mem::drop(&lock_guard) // Should have been drop(lock_guard), mutex // still locked operation_that_requires_mutex_to_be_unlocked(); ``` ### Explanation Calling `drop` or `forget` on a reference will only drop the reference itself, which is a no-op. It will not call the `drop` or `forget` method on the underlying referenced value, which is likely what was intended. ## `drop_copy` and `forget_copy` The `drop_copy` and `forget_copy` lint checks for calls to `std::mem::forget` or `std::mem::drop` with a value that derives the Copy trait. ### Example ```rust let x: i32 = 42; // i32 implements Copy std::mem::forget(x) // A copy of x is passed to the function, leaving the // original unaffected ``` ### Explanation Calling `std::mem::forget` [does nothing for types that implement Copy](https://doc.rust-lang.org/std/mem/fn.drop.html) since the value will be copied and moved into the function on invocation. ----- Followed the instructions for uplift a clippy describe here: rust-lang#99696 (review) cc `@m-ou-se` (as T-libs-api leader because the uplifting was discussed in a recent meeting)
Configuration menu - View commit details
-
Copy full SHA for 7f92747 - Browse repository at this point
Copy the full SHA 7f92747View commit details -
Rollup merge of rust-lang#109981 - duckymirror:issue-107094, r=albert…
…larsan68 Set commit information environment variables when building tools This fixes rust-lang#107094. ~I'm trying to add a regression test for this issue.~ **Update**: I've added a test and a new test header `needs-git-hash` which makes sure it doesn't run when commit hashes are ignored (`bootstrap`'s `ignore-git` option).
Configuration menu - View commit details
-
Copy full SHA for 578a8d8 - Browse repository at this point
Copy the full SHA 578a8d8View commit details -
Rollup merge of rust-lang#110348 - GuillaumeGomez:disambiguators-suff…
…ixes-rustdoc-book, r=Manishearth Add list of supported disambiguators and suffixes for intra-doc links in the rustdoc book This information is otherwise only provided in case an error occurs, which isn't great. r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for cfe6c94 - Browse repository at this point
Copy the full SHA cfe6c94View commit details -
Rollup merge of rust-lang#110407 - Nilstrieb:fluent-macro, r=davidtwco
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
Configuration menu - View commit details
-
Copy full SHA for 92888be - Browse repository at this point
Copy the full SHA 92888beView commit details -
Rollup merge of rust-lang#110409 - Nilstrieb:some-manual-javascript-o…
…bject-notationing, r=fee1-dead Don't use `serde_json` to serialize a simple JSON object This avoids `rustc_data_structures` depending on `serde_json` which allows it to be compiled much earlier, unlocking most of rustc. This used to not matter, but after rust-lang#110407 we're not blocked on fluent anymore, which means that it's now a blocking edge. ![image](https://user-images.githubusercontent.com/48135649/232313178-e0150420-3020-4eb6-98d3-fe5294a8f947.png) This saves a few more seconds. cc ``@Zoxc`` who added it recently
Configuration menu - View commit details
-
Copy full SHA for 6595372 - Browse repository at this point
Copy the full SHA 6595372View commit details