Commits on May 4, 2023

1. Don't print backtrace on ICEs in issue-86800.rs. …

   Because it then just has to be filtered out.
   
   This change makes this test more like these other tests:
   - tests/ui/treat-err-as-bug/err.rs
   - tests/ui/treat-err-as-bug/delay_span_bug.rs
   - tests/ui/mir/validate/storage-live.rs
   - tests/ui/associated-inherent-types/bugs/ice-substitution.rs
   - tests/ui/layout/valid_range_oob.rs

   

   nnethercote committed May 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8702591
   • Browse repository at this point

   Copy the full SHA

   8702591 View commit details

   Browse the repository at this point in the history

2. Improve filtering in default-backtrace-ice.rs. …

   This test is supposed to ensure that full backtraces are used for ICEs.
   But it doesn't actually do that -- the filtering done cannot distinguish
   between a full backtrace versus a short backtrace.
   
   So this commit changes the filtering to preserve the existence of
   `__rust_{begin,end}_short_backtrace` markers, which only appear in full
   backtraces. This change means the test now tests what it is supposed to
   test.
   
   Also, the existing filtering included a rule that excluded any line
   starting with two spaces. This was too strong because it filtered out
   some parts of the error message. (This was not a showstopper). It was
   also not strong enough because it didn't work with three digit stack
   frame numbers, which just started seeing after upgrading my Ubuntu
   distro to 23.04 machine (this *was* a showstopper).
   
   So the commit replaces that rule with two more precise rules, one for
   lines with stack frame numbers, and one for "at ..." lines.

   

   nnethercote committed May 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for f20738d
   • Browse repository at this point

   Copy the full SHA

   f20738d View commit details

   Browse the repository at this point in the history