Run tests on PGO/LTO/BOLT optimized dist artifacts #111495

Kobzol · 2023-05-12T06:10:43Z

This PR adds baisc tests for the optimized dist builds on x64 Linux and Windows. A subset of the test suite is run, so it's not perfect, but it's better than the status quo (which is basically no testing at all, apart from the perf bot on Linux).

r? @ghost

Kobzol · 2023-05-12T06:10:50Z

@bors try

bors · 2023-05-12T06:10:58Z

⌛ Trying commit 90573458adeb84d70d6a391531d2e43b749672b4 with merge 1578bd437936c76283c4070a1b947c418376889b...

bors · 2023-05-12T08:29:14Z

💔 Test failed - checks-actions

Kobzol · 2023-05-16T06:12:18Z

@bors try

bors · 2023-05-16T06:12:27Z

⌛ Trying commit 987bceb2241a8f1150d154f7a3f89e75721cd701 with merge b21ec54c4c582f2be85188049242941dc407f2eb...

bors · 2023-05-16T08:27:59Z

💔 Test failed - checks-actions

Noratrieb · 2023-05-16T09:48:05Z

nils-log-analyzer: standard library unit tests are failing with 2023-05-16T08:27:42.8919828Z = note: cc: error: unrecognized command line option '-fuse-ld=lld'; did you mean '-fuse-ld=bfd'?

2023-05-16T08:27:42.1705564Z ---- src/borrow.rs - borrow::Cow<'_,B>::into_owned (line 295) stdout ----
2023-05-16T08:27:42.1706185Z error: linking with `cc` failed: exit status: 1
2023-05-16T08:27:42.1706651Z   |
2023-05-16T08:27:42.1721278Z   = note: LC_ALL="C" PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/bin:/rustroot/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" VSLANG="1033" "cc" "-m64" "/tmp/rustcsxsZB9/symbols.o" "/tmp/rustdoctestqCBzBo/rust_out.rust_out.1f756438df49f6a7-cgu.0.rcgu.o" "/tmp/rustdoctestqCBzBo/rust_out.2cvunbsk2azhkzz6.rcgu.o" "-Wl,--as-needed" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/build/compiler_builtins-6c572a08dbd8d672/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/build/profiler_builtins-417f1d49882f20b2/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-edb03adabf0b22c8.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-56c2a42cc2d7381f.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libobject-fd705a60736c3357.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmemchr-c0ff7ddb2987d8da.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libaddr2line-c459f8b0a64f04e1.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-c2d64f918d4b26ad.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-d22c51811a78dc80.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_detect-d8ba7f24f3cb57da.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-2a372fbb5b41c14b.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-45ff23c614a38f1d.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libminiz_oxide-6b9410c3805b4c08.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libadler-6deb8c633abe47e3.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-57df4eca7d5785df.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-0b7d1529f62927c0.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-69a45ab5967387b5.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-c2c050aec00eb6da.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-522518611024dce5.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-05898138a596088a.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-35b8a4bd2de4e62e.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/tmp/rustdoctestqCBzBo/rust_out" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-fuse-ld=lld" "-Wl,--threads=1"
2023-05-16T08:27:42.1730717Z   = note: cc: error: unrecognized command line option '-fuse-ld=lld'; did you mean '-fuse-ld=bfd'?
2023-05-16T08:27:42.1731261Z           
2023-05-16T08:27:42.1731496Z 
2023-05-16T08:27:42.1731720Z error: aborting due to previous error

Kobzol · 2023-05-16T17:29:55Z

@bors try

bors · 2023-05-16T17:30:05Z

⌛ Trying commit 1277304c6c7efe1a8f8ad719cba6802cdda5362e with merge 2d652d40f2b3de4051b8a19d0edd568a970c8ac5...

bors · 2023-05-16T19:39:29Z

💔 Test failed - checks-actions

Kobzol · 2023-05-16T21:24:04Z

@bors try

bors · 2023-05-16T21:24:15Z

⌛ Trying commit 599b6528569d8466d23ff11b4117f53f904e89ab with merge 2a45095c02a3d5806241babc6b9a8429fff6d7c2...

bors · 2023-05-16T21:28:34Z

💔 Test failed - checks-actions

Kobzol · 2023-05-16T21:31:13Z

@bors try

bors · 2023-05-16T21:31:21Z

⌛ Trying commit f803c54bc8bf5b3fc86517cea647d7278f16b093 with merge a38e18762f3909cee6cb6556b957fc2d5e38e780...

bors · 2023-05-16T23:10:15Z

💔 Test failed - checks-actions

Kobzol · 2023-05-17T07:54:29Z

@bors try

bors · 2023-06-05T15:24:33Z

💔 Test failed - checks-actions

Kobzol · 2023-06-05T15:40:40Z

@bors try

bors · 2023-06-05T15:40:51Z

⌛ Trying commit 8ff1aaa9ca96b3d7cef6593be8ed1e801271783e with merge 7facc3d13f658d5c0f760310a4ce820c81011aad...

bors · 2023-06-05T17:33:31Z

☀️ Try build successful - checks-actions
Build commit: 7facc3d13f658d5c0f760310a4ce820c81011aad (7facc3d13f658d5c0f760310a4ce820c81011aad)

bors · 2023-06-05T17:33:31Z

☀️ Try build successful - checks-actions
Build commit: 7facc3d13f658d5c0f760310a4ce820c81011aad (7facc3d13f658d5c0f760310a4ce820c81011aad)

Kobzol · 2023-06-05T17:39:57Z

Good, Windows now works! Let's see if Linux also still works.

@bors try

bors · 2023-06-05T17:40:09Z

⌛ Trying commit fe120784fa8b1639154960ccdc6d15e1fa3776f2 with merge 25aae599a93f2d72984c9ea4575ada5fc2d9d856...

bors · 2023-06-05T19:53:20Z

☀️ Try build successful - checks-actions
Build commit: 25aae599a93f2d72984c9ea4575ada5fc2d9d856 (25aae599a93f2d72984c9ea4575ada5fc2d9d856)

bors · 2023-06-05T19:53:20Z

☀️ Try build successful - checks-actions
Build commit: 25aae599a93f2d72984c9ea4575ada5fc2d9d856 (25aae599a93f2d72984c9ea4575ada5fc2d9d856)

Kobzol · 2023-06-05T19:55:22Z

Good, now both Windows and Linux work 🎉

@rustbot ready

Mark-Simulacrum · 2023-06-06T11:00:07Z

@bors r+ rollup=never

bors · 2023-06-06T11:00:09Z

📌 Commit c91a3a4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2023-06-07T00:14:09Z

⌛ Testing commit c91a3a4 with merge 7b28a6b...

bors · 2023-06-07T03:20:07Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7b28a6b to master...

rust-timer · 2023-06-07T04:35:01Z

Finished benchmarking commit (7b28a6b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[5.1%, 5.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.37s -> 647.65s (0.04%)

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 12, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2023

Kobzol force-pushed the dist-tests branch from 9057345 to 987bceb Compare May 16, 2023 06:11

This comment has been minimized.

Sign in to view

Kobzol force-pushed the dist-tests branch from 8ff1aaa to fe12078 Compare June 5, 2023 17:39

Test the PGO/BOLT/LTO optimized x64 Linux compiler on CI

c91a3a4

Kobzol force-pushed the dist-tests branch from fe12078 to c91a3a4 Compare June 5, 2023 19:55

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2023

bors merged commit 7b28a6b into rust-lang:master Jun 7, 2023

rustbot added this to the 1.72.0 milestone Jun 7, 2023

Kobzol deleted the dist-tests branch June 7, 2023 06:27

Kobzol mentioned this pull request Jul 7, 2023

Run tests for dist builds #109535

Closed

Run tests on PGO/LTO/BOLT optimized dist artifacts #111495

Run tests on PGO/LTO/BOLT optimized dist artifacts #111495

Conversation

Kobzol commented May 12, 2023 • edited Loading

Kobzol commented May 12, 2023

bors commented May 12, 2023

bors commented May 12, 2023

Kobzol commented May 16, 2023

bors commented May 16, 2023

bors commented May 16, 2023

Noratrieb commented May 16, 2023

Kobzol commented May 16, 2023

bors commented May 16, 2023

bors commented May 16, 2023

Kobzol commented May 16, 2023

bors commented May 16, 2023

bors commented May 16, 2023

This comment has been minimized.

Kobzol commented May 16, 2023

bors commented May 16, 2023

bors commented May 16, 2023

This comment has been minimized.

Kobzol commented May 17, 2023

bors commented Jun 5, 2023

This comment has been minimized.

Kobzol commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

Kobzol commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

Kobzol commented Jun 5, 2023

Mark-Simulacrum commented Jun 6, 2023

bors commented Jun 6, 2023

bors commented Jun 7, 2023

bors commented Jun 7, 2023

rust-timer commented Jun 7, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Kobzol commented May 12, 2023 •

edited

Loading