Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build docs in try builds #111660

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 16, 2023

This PR adds a new environment variable to the optimized build Python script, which causes it to ignore certain parts of the final dist build (mainly docs) in try builds. This reduces the duration of try builds by ~10 minutes.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 16, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented May 16, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 16, 2023
@bors
Copy link
Contributor

bors commented May 16, 2023

⌛ Trying commit 5581afaeeec8008779fb33cd1343736ee5416bd2 with merge 2df3488ee81cdb91971e0c40ced4264dfd2fa873...

@bors
Copy link
Contributor

bors commented May 17, 2023

☀️ Try build successful - checks-actions
Build commit: 2df3488ee81cdb91971e0c40ced4264dfd2fa873 (2df3488ee81cdb91971e0c40ced4264dfd2fa873)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2df3488ee81cdb91971e0c40ced4264dfd2fa873): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.057s -> 645.098s (0.16%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 17, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

@bors try

@bors
Copy link
Contributor

bors commented May 17, 2023

⌛ Trying commit 33ff1be7382168b0a90f2c8b02cb12400fc2ebd0 with merge 9831f73112693bcff7b9706bc7d94cdb3a62e827...

@bors
Copy link
Contributor

bors commented May 17, 2023

☀️ Try build successful - checks-actions
Build commit: 9831f73112693bcff7b9706bc7d94cdb3a62e827 (9831f73112693bcff7b9706bc7d94cdb3a62e827)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

Hmm, this build took just 1h 35minutes, which is quite fast, but it was caused by something else (quick CI runner?), because everything was fast. The documentation is still being built.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

@bors try

@bors
Copy link
Contributor

bors commented May 17, 2023

⌛ Trying commit 3a1e44dd01882467acdce05e53bbef7dfca74d1a with merge 22dc5ccf43279db086b7c9e2879e602d6f1da6c8...

@bors
Copy link
Contributor

bors commented May 17, 2023

☀️ Try build successful - checks-actions
Build commit: 22dc5ccf43279db086b7c9e2879e602d6f1da6c8 (22dc5ccf43279db086b7c9e2879e602d6f1da6c8)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

@rust-timer build 22dc5ccf43279db086b7c9e2879e602d6f1da6c8

@rust-timer

This comment has been minimized.

@Kobzol Kobzol marked this pull request as ready for review May 17, 2023 15:51
@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

This is now ready for review.

r? @Mark-Simulacrum

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (22dc5ccf43279db086b7c9e2879e602d6f1da6c8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.7%, -2.0%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 643.044s -> 643.294s (0.04%)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 17, 2023

Perf can run without the missing components, good.

@Mark-Simulacrum
Copy link
Member

This makes it a little harder for us to produce e.g. dev-static artifacts for testing. I wonder if that's the right tradeoff to make, for a relatively small gain on try build times. I guess putting the doc builds into an entirely new builder is going to be very slow, since it needs to build a bunch of dependencies?

cc @rust-lang/infra if you have thoughts. I think I'm inclined to go ahead with this (r=me in 1 week).

@bors
Copy link
Contributor

bors commented May 31, 2023

☀️ Try build successful - checks-actions
Build commit: 08facb7a1b4e82191afe44e907fe50f715acc57d (08facb7a1b4e82191afe44e907fe50f715acc57d)

1 similar comment
@bors
Copy link
Contributor

bors commented May 31, 2023

☀️ Try build successful - checks-actions
Build commit: 08facb7a1b4e82191afe44e907fe50f715acc57d (08facb7a1b4e82191afe44e907fe50f715acc57d)

@rust-timer

This comment has been minimized.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 1, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jun 1, 2023

⌛ Trying commit db113b1 with merge 281576a7fc7c62e208d0c5aa742bf9259b928ee2...

@bors
Copy link
Contributor

bors commented Jun 1, 2023

☀️ Try build successful - checks-actions
Build commit: 281576a7fc7c62e208d0c5aa742bf9259b928ee2 (281576a7fc7c62e208d0c5aa742bf9259b928ee2)

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 1, 2023

@rust-timer build 281576a7fc7c62e208d0c5aa742bf9259b928ee2

Checking if the latest change didn't break perfbot again.

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (281576a7fc7c62e208d0c5aa742bf9259b928ee2): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.933s -> 643.494s (0.09%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 1, 2023

@bors r=mark-simulacrum

@bors
Copy link
Contributor

bors commented Jun 1, 2023

📌 Commit db113b1 has been approved by mark-simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2023
@bors
Copy link
Contributor

bors commented Jun 1, 2023

⌛ Testing commit db113b1 with merge d59363a...

@bors
Copy link
Contributor

bors commented Jun 1, 2023

☀️ Test successful - checks-actions
Approved by: mark-simulacrum
Pushing d59363a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2023
@bors bors merged commit d59363a into rust-lang:master Jun 1, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d59363a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.2%, 1.5%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.7% [4.4%, 5.0%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.7% [4.4%, 5.0%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-4.6%, -1.0%] 15
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) -2.2% [-4.6%, -1.0%] 15

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 645.554s -> 643.493s (-0.32%)

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 2, 2023

Hmm, I was worried for a while that the try build optimization was propagated into dist builds, but it does not seem like so, the dist build compiled all the artifacts. It's super weird though, where do the perf. changes come from :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants