Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #111671

Merged
merged 15 commits into from
May 17, 2023
Merged

Rollup of 6 pull requests #111671

merged 15 commits into from
May 17, 2023

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jmillikin and others added 15 commits May 1, 2023 11:00
It's just a short wrapper used by `tcx.require_lang_item`. Deleting it
gives us a negative diff.
This makes it easier to implement it for a type, just like `Copy`.
… r=Nilstrieb

Share slice of bytes

r? `@Nilstrieb`
cc `@noamtashma`
…Lapkin

Remove `LangItems::require`

It's just a short wrapper used by `tcx.require_lang_item`. Deleting it gives us a negative diff.
…=BoxyUwU

Add derive for `core::marker::ConstParamTy`

This makes it easier to implement it for a type, just like `Copy`.

`@BoxyUwU` half asked me to add it
…r=joshtriplett

Add a conversion from `&mut T` to `&mut UnsafeCell<T>`

Provides a safe way of downgrading an exclusive reference into an alias-able `&UnsafeCell<T>` reference.

ACP: rust-lang/libs-team#198.
… r=compiler-errors

Erase regions of type in `offset_of!`

Fixes rust-lang#111657
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 17, 2023
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented May 17, 2023

📌 Commit 0720743 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2023
@bors
Copy link
Contributor

bors commented May 17, 2023

⌛ Testing commit 0720743 with merge c2ccc85...

@bors
Copy link
Contributor

bors commented May 17, 2023

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing c2ccc85 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2023
@bors bors merged commit c2ccc85 into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#111661 c7c7cd812f1fbe7028127e7a54ccd7bb726a9458
#111654 1e5d00530fda6389f80836986c0d7a0fcca0e767
#111649 4438f4037818a34f87f7cc270c2e3086b47c6786
#111648 8fd5ff3857a71f490c030a328833c1fa89e9055c
#111043 d9568493fadc4a5cd548bc5331e40f99d0fdfad6
#110145 1ff606909706db429b0d246593dab93a80d1851d

previous master: 6c64870fa6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c2ccc85): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [0.7%, 3.1%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.0% [-5.0%, -5.0%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.6%, 2.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 643.359s -> 643.044s (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants