Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 16.0.4 #111672

Merged
merged 1 commit into from
May 18, 2023
Merged

Update to LLVM 16.0.4 #111672

merged 1 commit into from
May 18, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented May 17, 2023

Fixes #109918.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2023
@wesleywiser
Copy link
Member

Should this be nominated for beta backported since LLVM 16 landed in 1.70 (current beta)?

@nikic
Copy link
Contributor Author

nikic commented May 17, 2023

We could do that, but I don't think it's particularly important. The only fix here that is known to affect Rust is nightly-only.

@cuviper
Copy link
Member

cuviper commented May 17, 2023

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 17, 2023

📌 Commit c544fc3 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2023
@bors
Copy link
Contributor

bors commented May 17, 2023

⌛ Testing commit c544fc3 with merge 24c180c...

@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 24c180c to master...

1 similar comment
@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 24c180c to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels May 18, 2023
@bors bors merged commit 24c180c into rust-lang:master May 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (24c180c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.6% [3.6%, 3.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.487s -> 645.339s (0.44%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x86-interrupt calling convention with error code is broken on x86_64-unknown-none
6 participants