Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop normalizing so many different prefixes #111975

Merged
merged 1 commit into from
May 31, 2023
Merged

Commits on May 26, 2023

  1. Stop normalizing so many different prefixes

    Previously, we would normalize *all* of
    - the absolute path to the repository checkout
    - the /rustc/$sha for stage1 (if `remap-debuginfo` was enabled)
    - the /rustc/$sha for download-rustc
    - the sysroot for download-rustc
    
    Now, we consistently only normalize /rustc/FAKE_PREFIX. Not only is this
    much simpler, but it also avoids ongoing maintenance for download-rustc
    and makes it much less likely that tests break by accident.
    
    - Change `tests/ui/track-diagnostics/track6.rs` to use a relative path
      instead of an absolute one. I am not actually sure why `track_caller`
    works here, but it does seem to work 🤷
    
    - Pass `-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX` to all
      suites, not just UI. In particular, mir-opt tests emit /rustc/ paths
      in their output.
    jyn514 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    157d936 View commit details
    Browse the repository at this point in the history