-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #112111
Rollup of 6 pull requests #112111
Commits on Mar 28, 2023
-
`OsStr` has historically kept its implementation details private out of concern for locking us into a specific encoding on Windows. This is an alternative to rust-lang#95290 which proposed specifying the encoding on Windows. Instead, this only specifies that for cross-platform code, `OsStr`'s encoding is a superset of UTF-8 and defines rules for safely interacting with it At minimum, this can greatly simplify the `os_str_bytes` crate and every arg parser that interacts with `OsStr` directly (which is most of those that support invalid UTF-8).
Configuration menu - View commit details
-
Copy full SHA for 8d2beb5 - Browse repository at this point
Copy the full SHA 8d2beb5View commit details
Commits on May 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7f1a6cd - Browse repository at this point
Copy the full SHA 7f1a6cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b92903 - Browse repository at this point
Copy the full SHA 7b92903View commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f9aaad0 - Browse repository at this point
Copy the full SHA f9aaad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d177af - Browse repository at this point
Copy the full SHA 5d177afView commit details
Commits on May 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e6a35c4 - Browse repository at this point
Copy the full SHA e6a35c4View commit details
Commits on May 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5c780d9 - Browse repository at this point
Copy the full SHA 5c780d9View commit details
Commits on May 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cfd0623 - Browse repository at this point
Copy the full SHA cfd0623View commit details -
Configuration menu - View commit details
-
Copy full SHA for b573250 - Browse repository at this point
Copy the full SHA b573250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25f8f4c - Browse repository at this point
Copy the full SHA 25f8f4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c18d1e - Browse repository at this point
Copy the full SHA 6c18d1eView commit details
Commits on May 30, 2023
-
Remove
-Zcgu-partitioning-strategy
.This option was introduced three years ago, but it's never been meaningfully used, and `default` is the only acceptable value. Also, I think the `Partition` trait presents an interface that is too closely tied to the existing strategy and would probably be wrong for other strategies. (My rule of thumb is to not make something generic until there are at least two instances of it, to avoid this kind of problem.) Also, I don't think providing multiple partitioning strategies to the user is a good idea, because the compiler already has enough obscure knobs. This commit removes the option, along with the `Partition` trait, and the `Partitioner` and `DefaultPartitioning` types. I left the existing code in `compiler/rustc_monomorphize/src/partitioning/default.rs`, though I could be persuaded that moving it into `compiler/rustc_monomorphize/src/partitioning/mod.rs` is better.
Configuration menu - View commit details
-
Copy full SHA for 97d4a38 - Browse repository at this point
Copy the full SHA 97d4a38View commit details -
Within `compiler/rustc_monomorphize/src/partitioning/`, because the previous commit removed the need for `default.rs` to be a separate file.
Configuration menu - View commit details
-
Copy full SHA for 66cf072 - Browse repository at this point
Copy the full SHA 66cf072View commit details -
Rename
partitioning/mod.rs
aspartitioning.rs
.Because it's now the only file within `compiler/rustc_monomorphize/src/partitioning/`.
Configuration menu - View commit details
-
Copy full SHA for 5ed0149 - Browse repository at this point
Copy the full SHA 5ed0149View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a039d - Browse repository at this point
Copy the full SHA e3a039dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b694a03 - Browse repository at this point
Copy the full SHA b694a03View commit details -
Rollup merge of rust-lang#109698 - epage:wtf, r=Amanieu
Allow limited access to `OsStr` bytes `OsStr` has historically kept its implementation details private out of concern for locking us into a specific encoding on Windows. This is an alternative to rust-lang#95290 which proposed specifying the encoding on Windows. Instead, this only specifies that for cross-platform code, `OsStr`'s encoding is a superset of UTF-8 and defines rules for safely interacting with it At minimum, this can greatly simplify the `os_str_bytes` crate and every arg parser that interacts with `OsStr` directly (which is most of those that support invalid UTF-8). Tracking issue: rust-lang#111544
Configuration menu - View commit details
-
Copy full SHA for e898e7c - Browse repository at this point
Copy the full SHA e898e7cView commit details -
Rollup merge of rust-lang#112031 - sladyn98:migrate-proc-macro, r=Gui…
…llaumeGomez Migrate `item_proc_macro` to Askama This PR migrates `item_proc_macro` to Askama Refers rust-lang#108868
Configuration menu - View commit details
-
Copy full SHA for 658bd78 - Browse repository at this point
Copy the full SHA 658bd78View commit details -
Rollup merge of rust-lang#112053 - nnethercote:rm-Zcpu-partitioning-s…
…trategy, r=wesleywiser Remove `-Zcgu-partitioning-strategy`. This option was introduced three years ago, but it's never been meaningfully used, and `default` is the only acceptable value. Also, I think the `Partition` trait presents an interface that is too closely tied to the existing strategy and would probably be wrong for other strategies. (My rule of thumb is to not make something generic until there are at least two instances of it, to avoid this kind of problem.) Also, I don't think providing multiple partitioning strategies to the user is a good idea, because the compiler already has enough obscure knobs. This commit removes the option, along with the `Partition` trait, and the `Partitioner` and `DefaultPartitioning` types. I left the existing code in `compiler/rustc_monomorphize/src/partitioning/default.rs`, though I could be persuaded that moving it into `compiler/rustc_monomorphize/src/partitioning/mod.rs` is better. r? `@wesleywiser`
Configuration menu - View commit details
-
Copy full SHA for 9897757 - Browse repository at this point
Copy the full SHA 9897757View commit details -
Rollup merge of rust-lang#112069 - clubby789:offset-of-sized-fields, …
…r=WaffleLapkin offset_of: don't require type to be `Sized` Fixes rust-lang#112051 ~~The RFC [explicitly forbids](https://rust-lang.github.io/rfcs/3308-offset_of.html#limitations) non-`Sized` types, but it looks like only the fields being recursed into were checked. The sized check also seemed to have been completely missing for tuples~~
Configuration menu - View commit details
-
Copy full SHA for 02d58ab - Browse repository at this point
Copy the full SHA 02d58abView commit details -
Rollup merge of rust-lang#112070 - lcnr:disjoint-closure-capture-ub, …
…r=oli-obk change `BorrowKind::Unique` to be a mutating `PlaceContext` fixes rust-lang#112056 I believe that `BorrowKind::Unique` is a footgun in general, so I added a FIXME and opened rust-lang#112072. This is a bit too involved for this PR though.
Configuration menu - View commit details
-
Copy full SHA for f00651c - Browse repository at this point
Copy the full SHA f00651cView commit details -
Rollup merge of rust-lang#112071 - WaffleLapkin:group-rfcs-tests, r=o…
…li-obk Group rfcs tests This moves all RFC tests to `tests/ui/rfcs/rfc-NNNN-title-title-title/...` I had to rename some tests due to conflicts, but otherwise this is just a move.
Configuration menu - View commit details
-
Copy full SHA for 3b49aa0 - Browse repository at this point
Copy the full SHA 3b49aa0View commit details