Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #112111

Closed
wants to merge 22 commits into from
Closed

Commits on Mar 28, 2023

  1. Allow access to OsStr bytes

    `OsStr` has historically kept its implementation details private out of
    concern for locking us into a specific encoding on Windows.
    
    This is an alternative to rust-lang#95290 which proposed specifying the encoding on Windows.  Instead, this
    only specifies that for cross-platform code, `OsStr`'s encoding is a superset of UTF-8 and defines
    rules for safely interacting with it
    
    At minimum, this can greatly simplify the `os_str_bytes` crate and every
    arg parser that interacts with `OsStr` directly (which is most of those
    that support invalid UTF-8).
    epage committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8d2beb5 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Configuration menu
    Copy the full SHA
    7f1a6cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b92903 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    f9aaad0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d177af View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. docs: Add missing period

    epage committed May 20, 2023
    Configuration menu
    Copy the full SHA
    e6a35c4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. Migrate to Askama

    sladyn98 committed May 28, 2023
    Configuration menu
    Copy the full SHA
    5c780d9 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. unique borrows are mutating uses

    lcnr committed May 29, 2023
    Configuration menu
    Copy the full SHA
    cfd0623 View commit details
    Browse the repository at this point in the history
  2. add tests

    lcnr committed May 29, 2023
    Configuration menu
    Copy the full SHA
    b573250 View commit details
    Browse the repository at this point in the history
  3. add FIXME

    lcnr committed May 29, 2023
    Configuration menu
    Copy the full SHA
    25f8f4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c18d1e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Remove -Zcgu-partitioning-strategy.

    This option was introduced three years ago, but it's never been
    meaningfully used, and `default` is the only acceptable value.
    
    Also, I think the `Partition` trait presents an interface that is too
    closely tied to the existing strategy and would probably be wrong for
    other strategies. (My rule of thumb is to not make something generic
    until there are at least two instances of it, to avoid this kind of
    problem.)
    
    Also, I don't think providing multiple partitioning strategies to the
    user is a good idea, because the compiler already has enough obscure
    knobs.
    
    This commit removes the option, along with the `Partition` trait, and
    the `Partitioner` and `DefaultPartitioning` types. I left the existing
    code in `compiler/rustc_monomorphize/src/partitioning/default.rs`,
    though I could be persuaded that moving it into
    `compiler/rustc_monomorphize/src/partitioning/mod.rs` is better.
    nnethercote committed May 30, 2023
    Configuration menu
    Copy the full SHA
    97d4a38 View commit details
    Browse the repository at this point in the history
  2. Merge default.rs into mod.rs.

    Within `compiler/rustc_monomorphize/src/partitioning/`, because the
    previous commit removed the need for `default.rs` to be a separate file.
    nnethercote committed May 30, 2023
    Configuration menu
    Copy the full SHA
    66cf072 View commit details
    Browse the repository at this point in the history
  3. Rename partitioning/mod.rs as partitioning.rs.

    Because it's now the only file within
    `compiler/rustc_monomorphize/src/partitioning/`.
    nnethercote committed May 30, 2023
    Configuration menu
    Copy the full SHA
    5ed0149 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3a039d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b694a03 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#109698 - epage:wtf, r=Amanieu

    Allow limited access to `OsStr` bytes
    
    `OsStr` has historically kept its implementation details private out of
    concern for locking us into a specific encoding on Windows.
    
    This is an alternative to rust-lang#95290 which proposed specifying the encoding on Windows.  Instead, this
    only specifies that for cross-platform code, `OsStr`'s encoding is a superset of UTF-8 and defines
    rules for safely interacting with it
    
    At minimum, this can greatly simplify the `os_str_bytes` crate and every
    arg parser that interacts with `OsStr` directly (which is most of those
    that support invalid UTF-8).
    
    Tracking issue: rust-lang#111544
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    e898e7c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#112031 - sladyn98:migrate-proc-macro, r=Gui…

    …llaumeGomez
    
    Migrate  `item_proc_macro` to Askama
    
    This PR migrates `item_proc_macro` to Askama
    
    Refers rust-lang#108868
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    658bd78 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#112053 - nnethercote:rm-Zcpu-partitioning-s…

    …trategy, r=wesleywiser
    
    Remove `-Zcgu-partitioning-strategy`.
    
    This option was introduced three years ago, but it's never been meaningfully used, and `default` is the only acceptable value.
    
    Also, I think the `Partition` trait presents an interface that is too closely tied to the existing strategy and would probably be wrong for other strategies. (My rule of thumb is to not make something generic until there are at least two instances of it, to avoid this kind of problem.)
    
    Also, I don't think providing multiple partitioning strategies to the user is a good idea, because the compiler already has enough obscure knobs.
    
    This commit removes the option, along with the `Partition` trait, and the `Partitioner` and `DefaultPartitioning` types. I left the existing code in `compiler/rustc_monomorphize/src/partitioning/default.rs`, though I could be persuaded that moving it into
    `compiler/rustc_monomorphize/src/partitioning/mod.rs` is better.
    
    r? `@wesleywiser`
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    9897757 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#112069 - clubby789:offset-of-sized-fields, …

    …r=WaffleLapkin
    
    offset_of: don't require type to be `Sized`
    
    Fixes rust-lang#112051
    
    ~~The RFC [explicitly forbids](https://rust-lang.github.io/rfcs/3308-offset_of.html#limitations) non-`Sized` types, but it looks like only the fields being recursed into were checked. The sized check also seemed to have been completely missing for tuples~~
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    02d58ab View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#112070 - lcnr:disjoint-closure-capture-ub, …

    …r=oli-obk
    
    change `BorrowKind::Unique` to be a mutating `PlaceContext`
    
    fixes rust-lang#112056
    
    I believe that `BorrowKind::Unique` is a footgun in general, so I added a FIXME and opened rust-lang#112072. This is a bit too involved for this PR though.
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    f00651c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#112071 - WaffleLapkin:group-rfcs-tests, r=o…

    …li-obk
    
    Group rfcs tests
    
    This moves all RFC tests to `tests/ui/rfcs/rfc-NNNN-title-title-title/...`
    
    I had to rename some tests due to conflicts, but otherwise this is just a move.
    Dylan-DPC authored May 30, 2023
    Configuration menu
    Copy the full SHA
    3b49aa0 View commit details
    Browse the repository at this point in the history