fix(suggestion): insert projection to associated types #112123

bvanjoi · 2023-05-31T02:13:04Z

This PR has fixed some help suggestions for unsupported syntax, such as fn f<T>(_:T) where T: IntoIterator, std::iter::IntoIterator::Item = () {} to fn f<T: IntoIterator<Item = ()>>(_T) {}.

rustbot · 2023-05-31T02:13:12Z

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

the8472 · 2023-06-08T16:12:20Z

compiler/rustc_hir_analysis/src/check/mod.rs

+                        .collect::<Vec<_>>()
+                        .join(" + ");


You may be able to use .intersperse(" + ").collect::<String>() here. Dogfooding unstable std features is usually ok in the compiler.

https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.intersperse

You'd need .intersperse(" + ".to_owned()) though, which is meh

compiler/rustc_hir_analysis/src/check/mod.rs

WaffleLapkin · 2023-06-26T09:28:00Z

r? wg-diagnostics

TaKO8Ki · 2023-06-27T14:14:15Z

I'll review it when I have time.

Dylan-DPC · 2023-08-15T09:54:49Z

@bvanjoi any updates on this?

bvanjoi · 2023-08-15T10:46:31Z

Hello @TaKO8Ki, just a friendly reminder when you have time, could you please review this?

bvanjoi · 2023-08-15T10:47:52Z

compiler/rustc_hir_analysis/src/check/mod.rs

+                        let def_path = tcx.def_path(alias_ty.def_id);
+                        projections_str.push(format!(
+                            "{} = {}",
+                            def_path.data.last().unwrap(),


I'm uncertain whether it's safe to use unwrap in this context

I think it's easier to just get tcx.item_name(alias_ty.def_id) to get the name of the associated type

Should RPITIT be skipped here?

RPITITs shouldn't show up here anyways, or else I'd consider that a bug in the caller?

RPITITs shouldn't show up here anyways

Sorry, I am slightly perplexed by this case. To clarify, considering the following code:

trait TraitA { type A; } trait TraitB<T> { fn f(&self) -> impl TraitA<Item = T>; } struct X; impl TraitB<u8> for X {}

Are you suggesting that we should avoid displaying the help message for implement the missing item: 'fn f(&self) -> impl TraitB<Item = u8> { todo!() }' ?

bvanjoi · 2023-08-21T14:05:58Z

It appears that TaKO8Ki is busy, so r? @compiler-errors

compiler-errors · 2023-09-18T22:29:04Z

For the record, this is still waiting on author.

compiler/rustc_hir_analysis/src/check/mod.rs

compiler-errors · 2023-09-28T22:41:42Z

Sorry @bvanjoi -- next time, please ping me when I fail to review your PRs in a timely fashion.

@bors r+

bors · 2023-09-28T22:41:45Z

📌 Commit 0341fcd has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-09-28T23:24:44Z

⌛ Testing commit 0341fcd with merge 57fa0fa...

fix(suggestion): insert projection to associated types Fixes rust-lang#98562 This PR has fixed some help suggestions for unsupported syntax, such as `fn f<T>(_:T) where T: IntoIterator, std::iter::IntoIterator::Item = () {}` to `fn f<T: IntoIterator<Item = ()>>(_T) {}`.

bors · 2023-09-29T00:02:42Z

💔 Test failed - checks-actions

bvanjoi · 2023-09-29T11:03:51Z

I'm unsure why the CI failed, as I couldn't reproduce this error when executing ./x.py test src/book.

Nonetheless, I've rebased with the master and forcefully pushed the changes again.

WaffleLapkin · 2023-09-29T18:52:18Z

@bors r=compiler-errors

bors · 2023-09-29T18:52:20Z

📌 Commit b83dfb5 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112123 (fix(suggestion): insert projection to associated types) - rust-lang#116024 (Implement Region for smir) - rust-lang#116030 (run abi/compatibility test against a whole bunch of targets) - rust-lang#116216 (ci: upgrade to crosstool-ng 1.26.0) - rust-lang#116241 (Add Exclusive forwarding impls (FnOnce, FnMut, Generator)) - rust-lang#116263 (More fixes for running the test suite on a bare metal target) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#112123 - bvanjoi:fix-98562, r=compiler-errors fix(suggestion): insert projection to associated types Fixes rust-lang#98562 This PR has fixed some help suggestions for unsupported syntax, such as `fn f<T>(_:T) where T: IntoIterator, std::iter::IntoIterator::Item = () {}` to `fn f<T: IntoIterator<Item = ()>>(_T) {}`.

rustbot assigned WaffleLapkin May 31, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 31, 2023

bvanjoi force-pushed the fix-98562 branch from 6373216 to 7323d9f Compare May 31, 2023 04:51

the8472 reviewed Jun 8, 2023

View reviewed changes

WaffleLapkin reviewed Jun 8, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/check/mod.rs Outdated Show resolved Hide resolved

WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2023

bvanjoi force-pushed the fix-98562 branch from 7323d9f to 9abdd42 Compare June 9, 2023 08:28

bvanjoi commented Jun 9, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/check/mod.rs Show resolved Hide resolved

bvanjoi commented Jun 9, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/check/mod.rs Show resolved Hide resolved

rustbot assigned TaKO8Ki and unassigned WaffleLapkin Jun 26, 2023

bvanjoi commented Aug 15, 2023

View reviewed changes

bvanjoi force-pushed the fix-98562 branch from 9abdd42 to 0341fcd Compare August 21, 2023 14:04

rustbot assigned compiler-errors and unassigned TaKO8Ki Aug 21, 2023

compiler-errors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2023

compiler-errors approved these changes Sep 28, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/check/mod.rs Show resolved Hide resolved

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 28, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2023

fix(suggestion): insert projection to associated types

b83dfb5

bvanjoi force-pushed the fix-98562 branch from 0341fcd to b83dfb5 Compare September 29, 2023 11:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2023

matthiaskrgr mentioned this pull request Sep 29, 2023

Rollup of 6 pull requests #116275

Merged

bors merged commit 4a88646 into rust-lang:master Sep 29, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 29, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(suggestion): insert projection to associated types #112123

fix(suggestion): insert projection to associated types #112123

bvanjoi commented May 31, 2023 •

edited

Loading

rustbot commented May 31, 2023

the8472 Jun 8, 2023

WaffleLapkin Jun 8, 2023

WaffleLapkin commented Jun 26, 2023

TaKO8Ki commented Jun 27, 2023

Dylan-DPC commented Aug 15, 2023

bvanjoi commented Aug 15, 2023

bvanjoi Aug 15, 2023

compiler-errors Aug 16, 2023

cjgillot Aug 16, 2023

compiler-errors Aug 16, 2023

bvanjoi Sep 19, 2023

bvanjoi commented Aug 21, 2023

compiler-errors commented Sep 18, 2023

compiler-errors commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

This comment has been minimized.

bors commented Sep 29, 2023

bvanjoi commented Sep 29, 2023

WaffleLapkin commented Sep 29, 2023

bors commented Sep 29, 2023

fix(suggestion): insert projection to associated types #112123

fix(suggestion): insert projection to associated types #112123

Conversation

bvanjoi commented May 31, 2023 • edited Loading

rustbot commented May 31, 2023

the8472 Jun 8, 2023

Choose a reason for hiding this comment

WaffleLapkin Jun 8, 2023

Choose a reason for hiding this comment

WaffleLapkin commented Jun 26, 2023

TaKO8Ki commented Jun 27, 2023

Dylan-DPC commented Aug 15, 2023

bvanjoi commented Aug 15, 2023

bvanjoi Aug 15, 2023

Choose a reason for hiding this comment

compiler-errors Aug 16, 2023

Choose a reason for hiding this comment

cjgillot Aug 16, 2023

Choose a reason for hiding this comment

compiler-errors Aug 16, 2023

Choose a reason for hiding this comment

bvanjoi Sep 19, 2023

Choose a reason for hiding this comment

bvanjoi commented Aug 21, 2023

compiler-errors commented Sep 18, 2023

compiler-errors commented Sep 28, 2023

bors commented Sep 28, 2023

bors commented Sep 28, 2023

This comment has been minimized.

bors commented Sep 29, 2023

bvanjoi commented Sep 29, 2023

WaffleLapkin commented Sep 29, 2023

bors commented Sep 29, 2023

bvanjoi commented May 31, 2023 •

edited

Loading