Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in rustdoc/src/what-is-rustdoc.md #112741

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix typo in rustdoc/src/what-is-rustdoc.md #112741

merged 1 commit into from
Jul 17, 2023

Conversation

geometryolife
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2023
workingjubilee
workingjubilee reviewed Jul 16, 2023
View reviewed changes
src/doc/rustdoc/src/what-is-rustdoc.md
Comment on lines 39 to 41
There are two problems with this: first, why does it
think that our package is named "lib"? Second, why does it not have any
think that our crate is named "lib"? Second, why does it not have any
contents?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not immediately clear to me that this is a typo, as Rust has packages and packages are not crates, see https://doc.rust-lang.org/book/ch07-01-packages-and-crates.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rust-lang/rust/pull/112741/files#diff-3a33d0f38f7a3cd5deb856ff984abfbcdcdb5adc9203734e739a1572ca2a3a1fR34

According to the description of the context, I think it is more appropriate to use crate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, well-spotted!

@workingjubilee
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 17, 2023

📌 Commit d456d11 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#112741 - geometryolife:fix, r=workingjubilee
e467a66 
fix typo in `rustdoc/src/what-is-rustdoc.md`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 17, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2023
@bors
Auto merge of rust-lang#113782 - matthiaskrgr:rollup-mmrjvx3, r=matth…
1a8d094 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112741 (fix typo in `rustdoc/src/what-is-rustdoc.md`)
 - rust-lang#113535 (Add a sparc-unknown-none-elf target.)
 - rust-lang#113651 (self type param infer, avoid ICE)
 - rust-lang#113770 (Generate safe stable code for derives on empty enums)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cfeeab5 into rust-lang:master Jul 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@geometryolife @rustbot @workingjubilee @bors @jsha