-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style-guide: Organizational and editing tweaks (no semantic changes) #112942
Commits on Jun 22, 2023
-
style-guide: Move text about block vs visual indent to indentation se…
…ction `principles.md` includes some high-level guiding principles for formatting, but also includes a few specific formatting provisions. While those provisions apply in many places, the same holds true for other high-level guidance, such as the indentation section. Move the text about using block indent rather than visual indent to the indentation section, so that `principles.md` can focus on guiding principles while the top level of the style guide gives concrete formatting recommendations.
Configuration menu - View commit details
-
Copy full SHA for 3747d7f - Browse repository at this point
Copy the full SHA 3747d7fView commit details -
style-guide: Move and expand text about trailing commas
`principles.md` includes some high-level guiding principles for formatting, but also includes a few specific formatting provisions. While those provisions apply in many places, the same holds true for other high-level guidance. Move the text about trailing commas to `README.md`, so that `principles.md` can focus on guiding principles while the top level of the style guide gives concrete formatting recommendations.
Configuration menu - View commit details
-
Copy full SHA for 9280567 - Browse repository at this point
Copy the full SHA 9280567View commit details -
style-guide: s/right-ward/rightward/
We already use the word "rightward" elsewhere; avoid the unnecessarily hyphenated "right-ward".
Configuration menu - View commit details
-
Copy full SHA for 2c0dd90 - Browse repository at this point
Copy the full SHA 2c0dd90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c5bb06 - Browse repository at this point
Copy the full SHA 4c5bb06View commit details -
style-guide: Remove inaccurate statement about rustfmt
rustfmt does include a mechanism to distinguish standard library imports, which it does syntactically by crate name. Avoid making a misleading statement that implies it cannot do this.
Configuration menu - View commit details
-
Copy full SHA for d270af3 - Browse repository at this point
Copy the full SHA d270af3View commit details -
style-guide: Define (and capitalize) "ASCIIbetically"
The style guide didn't give any definition for it.
Configuration menu - View commit details
-
Copy full SHA for c5f8b2c - Browse repository at this point
Copy the full SHA c5f8b2cView commit details -
style-guide: Update cargo.md for authors being optional and not recom…
…mended Change an example using the authors field to use a long feature list instead. Change the conventions for the authors field to say "if present".
Configuration menu - View commit details
-
Copy full SHA for 20f2828 - Browse repository at this point
Copy the full SHA 20f2828View commit details -
style-guide: Avoid normative recommendations for formatting tool conf…
…igurability It's not within the scope of the style guide to tell formatting tools whether, or how, to allow configurability of non-default formatting.
Configuration menu - View commit details
-
Copy full SHA for 6f8f83f - Browse repository at this point
Copy the full SHA 6f8f83fView commit details -
style-guide: Clarify advice on names matching keywords
In particular, specify what this advice is an alternative to (creative misspellings such as `krate`).
Configuration menu - View commit details
-
Copy full SHA for fec28b2 - Browse repository at this point
Copy the full SHA fec28b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c930b21 - Browse repository at this point
Copy the full SHA c930b21View commit details -
style-guide: Rephrase a confusingly ordered, ambiguous sentence (and …
…fix a typo) This sentence had a parenthetical without a closing parenthesis, and had the phrase "which doesn't require special formatting" ambiguously at the end of a list when it only applied to the last item of the list.
Configuration menu - View commit details
-
Copy full SHA for 3e2449c - Browse repository at this point
Copy the full SHA 3e2449cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d1db3 - Browse repository at this point
Copy the full SHA a9d1db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d63721 - Browse repository at this point
Copy the full SHA 5d63721View commit details -
Configuration menu - View commit details
-
Copy full SHA for f972e09 - Browse repository at this point
Copy the full SHA f972e09View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc23a3 - Browse repository at this point
Copy the full SHA fcc23a3View commit details