Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #113014

Merged
merged 17 commits into from
Jun 25, 2023
Merged

Rollup of 5 pull requests #113014

merged 17 commits into from
Jun 25, 2023

Commits on Jun 22, 2023

  1. Align search results horizontally for easy scanning

    The recent PR rust-lang#110688 added info about an item's kind before its name in
    search results. However, because the kind and name are inline with no
    alignment, it's now hard to visually scan downward through the search
    results, looking at item names. This PR fixes that by horizontally
    aligning search results such that there are now two columns of
    information.
    camelid committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a8fa961 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    6f61f6b View commit details
    Browse the repository at this point in the history
  2. Expose compiler-builtins-weak-intrinsics feature for -Zbuild-std

    This was added in rust-lang/compiler-builtins#526 to force all
    compiler-builtins intrinsics to use weak linkage.
    Amanieu committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    4a9f292 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c4fca72 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    12de5b7 View commit details
    Browse the repository at this point in the history
  5. Reduce typename width to 6.25rem

    This makes "existential type" look slightly cramped (though still
    readable), but it makes all other typenames look better. Existential
    types are currently very rare, and we can always tweak this later if
    necessary.
    camelid committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    5f433f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. outline x.py alternate invocations to the dev guide

    almost no one on windows builds from source unless they're contributing,
    and `./x.py` just works on most unix systems.
    jyn514 committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    b556e28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd314f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2eff0d View commit details
    Browse the repository at this point in the history
  4. Give a better error on Windows if python isn't installed

    Before:
    
    ```
    PS C:\Users\vboxuser\rust> ./x
    x.ps1
    
    PS C:\Users\vboxuser\rust>
    ```
    
    After:
    ```
    PS C:\Users\vboxuser\rust> ./x
    x.ps1
    
    C:\Users\vboxuser\rust\x.ps1 : C:\Users\vboxuser\rust\x.ps1: error: did not find python installed
    help: consider installing it from https://www.python.org/downloads/windows/
    At line:1 char:1
    + ./x
    + ~~~
        + CategoryInfo          : NotInstalled: (:) [Write-Error], WriteErrorException
        + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,x.ps1
    ```
    
    The existing message from the shell script is already decent and I decided not to change it:
    ```
    $ ./x
    Python was not found but can be installed from the Microsoft Store: ms-windows-store://pdp/?productid=9NJ46SX7X90P
    ```
    jyn514 committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    fa7e965 View commit details
    Browse the repository at this point in the history
  5. Don't print "x.ps1"

    This is left over from adding `Get-Command -syntax`; it's not helpful.
    jyn514 committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    664ffa4 View commit details
    Browse the repository at this point in the history
  6. rustdoc: Update GUI test

    camelid committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    9b97ae1 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Rollup merge of rust-lang#112937 - camelid:align-typenames, r=notridd…

    …le,GuillaumeGomez
    
    rustdoc: Align search results horizontally for easy scanning
    
    The recent PR rust-lang#110688 added info about an item's kind before its name in
    search results. However, because the kind and name are inline with no
    alignment, it's now hard to visually scan downward through the search
    results, looking at item names. This PR fixes that by horizontally
    aligning search results such that there are now two columns of
    information.
    
    r? `@GuillaumeGomez`
    matthiaskrgr authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    8816f9e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#112950 - tshepang:patch-4, r=Mark-Simulacrum

    DirEntry::file_name: improve explanation
    matthiaskrgr authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    8630b1b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#112956 - Amanieu:weak-intrinsics, r=Mark-Si…

    …mulacrum
    
    Expose `compiler-builtins-weak-intrinsics` feature for `-Zbuild-std`
    
    This was added in rust-lang/compiler-builtins#526 to force all compiler-builtins intrinsics to use weak linkage.
    matthiaskrgr authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    2ed4368 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#113008 - jyn514:new-contributor-improvement…

    …s, r=clubby789
    
    Move some docs from the README to the dev-guide
    
    and as a drive-by cleanup, improve the error message for `x test tidy` when a feature gate is missing.
    
    This also improves the error message you get on Windows if python isn't installed.
    
    cc rust-lang/libs-team#242 (comment), rust-lang/rustc-dev-guide#1701
    matthiaskrgr authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    85a7bb4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#113009 - ChrisDenton:remove-path, r=working…

    …jubilee
    
    Remove unnecessary `path` attribute
    
    Follow up to rust-lang#111401. I missed this at the time but it should now be totally unnecessary since the other include was removed.
    
    r? `@workingjubilee`
    matthiaskrgr authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    4824788 View commit details
    Browse the repository at this point in the history