Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Elaboratable trait take clauses #113144

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

compiler-errors
Copy link
Member

We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of .expect_clause() calls everywhere.

@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 29, 2023
@compiler-errors
Copy link
Member Author

compiler-errors commented Jun 29, 2023

r? @oli-obk (since you've been reviewing the clause rewrite code)

@rustbot rustbot assigned oli-obk and unassigned eholk Jun 29, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 29, 2023

Is there a chance we'll be able to remove the Predicate impls of elaborator at some point?

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 29, 2023

📌 Commit aafc801 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2023
… r=oli-obk

Make the `Elaboratable` trait take clauses

We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of `.expect_clause()` calls everywhere.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 30, 2023
… r=oli-obk

Make the `Elaboratable` trait take clauses

We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of `.expect_clause()` calls everywhere.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#111322 (Support for native WASM exceptions)
 - rust-lang#112086 (resolve: Remove artificial import ambiguity errors)
 - rust-lang#112234 (refactor `tool_doc!`)
 - rust-lang#112300 (Convert `run-make/coverage-reports` tests to use a custom compiletest mode)
 - rust-lang#112795 (Migrate some rustc_builtin_macros to SessionDiagnostic)
 - rust-lang#113144 (Make the `Elaboratable` trait take clauses)
 - rust-lang#113161 (Fix type privacy lints error message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5d74664 into rust-lang:master Jun 30, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 30, 2023
@compiler-errors compiler-errors deleted the elaborate-clauses branch August 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants