User may want to skip tidy check sometimes #113206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? @Kobzol |
|
This won't have an effect for people that already have the hook installed, but that's not such an issue, since this PR is aimed towards future new contributors anyway. I have tested it locally that it works. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113072 (str docs: remove "Basic usage" text where not useful) - rust-lang#113153 (make HashMap::or_insert_with example more simple) - rust-lang#113185 (Set `channel = nightly` in dist profile) - rust-lang#113186 (document that the panic in collect_intra_doc_links is load-bearing) - rust-lang#113187 (No need to distinguish `LocalTy` from `Ty`) - rust-lang#113189 (compiletest: Only trim the end of process output) - rust-lang#113191 (Update browser-ui-test version and improve GUI test) - rust-lang#113206 (User may want to skip tidy check sometimes) r? `@ghost` `@rustbot` modify labels: rollup
tgross35
reviewed
Jun 30, 2023
Comment on lines
17
to
+18
| ./x test tidy --set build.locked-deps=true | ||
| if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
Suggested change
| ./x test tidy --set build.locked-deps=true | |
| if [ $? -ne 0 ]; then | |
| res=ok | |
| ./x test tidy --set build.locked-deps=true || res=fail | |
| if [ "$res" != 0 ]; then |
Probably too late, but you could do something like this to not need to disable the -e flag. Not really needed anyway in this tiny script though
There was a problem hiding this comment.
nice trick!
but it should be:
if [ "$res" != "ok" ]; thenright?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113135