Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler builtins #113269

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 2, 2023

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@klensy
Copy link
Contributor

klensy commented Jul 2, 2023

#113046 (comment)

@jyn514
Copy link
Member Author

jyn514 commented Jul 2, 2023

yes i know, i'm replicating the failure so i know whether I've fixed it properly or not

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 2, 2023
@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member Author

jyn514 commented Jul 2, 2023

cool, that seems to have worked

@jyn514
Copy link
Member Author

jyn514 commented Jul 5, 2023

r? @Amanieu

@jyn514
Copy link
Member Author

jyn514 commented Jul 5, 2023

@bors rollup=iffy

@rust-log-analyzer

This comment has been minimized.

This pulls in the new `outline-atomics` intrinsics.
@Amanieu
Copy link
Member

Amanieu commented Jul 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2023

📌 Commit fd7f531 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@bors
Copy link
Contributor

bors commented Jul 6, 2023

⌛ Testing commit fd7f531 with merge 85bf079...

@bors
Copy link
Contributor

bors commented Jul 6, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 85bf079 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2023
@bors bors merged commit 85bf079 into rust-lang:master Jul 6, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 6, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (85bf079): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
-2.9% [-3.0%, -2.8%] 3
All ❌✅ (primary) 0.1% [-2.4%, 2.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 659.929s -> 658.38s (-0.23%)

@jyn514 jyn514 deleted the update-compiler-builtins branch July 7, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
7 participants